Skip to content

Commit 4bc74e6

Browse files
GarbeeG-Rath
andauthored
fix: remove unneeded dependencies (#492)
This pull request removes several unnecessary or outdated gem dependencies from the `axe-core` family of gems. The main focus is on cleaning up the gemspec files to ensure that only required dependencies are included, which helps reduce bloat and potential conflicts. It pulls in the changes from #481 since external contributors can't trigger Circle CI runs for inclusion. Dependency cleanup: * Removed the `dumb_delegator` dependency from the gemspecs of `axe-core-capybara`, `axe-core-selenium`, and `axe-core-watir` as it is no longer needed. [[1]](diffhunk://#diff-7f8ca1a6a00348dc0190b3d2f4d025e951680b14f76b81abebfa5c2f97d391c5L25) [[2]](diffhunk://#diff-97e5ebc112ab6dd049826902e0231dd18d45291bfffa6ce153730a1323822dcbL25) [[3]](diffhunk://#diff-b66c067ba3fb5beb0ed7d95e27dd2fff7d428f8708501da3a667cbf267615574L25) * Removed the `dumb_delegator`, `ostruct`, and `virtus` dependencies from the gemspecs of `axe-core-cucumber` and `axe-core-rspec`, as these are either no longer used or no longer necessary due to upstream changes. [[1]](diffhunk://#diff-bd8695c1c5a10077f9804c4305dacda37f66978addb0ef22d4105a11467bf63dL25-L29) [[2]](diffhunk://#diff-179c347b4ab40abb3e397a9c5f13ee0555432597468a8cc9788fc941844928caL25-L29) No QA Required --------- Co-authored-by: Gareth Jones <3151613+G-Rath@users.noreply.github.com>
1 parent ce573bc commit 4bc74e6

8 files changed

Lines changed: 25 additions & 30 deletions

File tree

packages/axe-core-capybara/Gemfile.lock

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
PATH
22
remote: ..
33
specs:
4-
axe-core-api (4.8.0)
4+
axe-core-api (4.11.1)
55
dumb_delegator
6+
ostruct
67
virtus
78

89
PATH
910
remote: .
1011
specs:
11-
axe-core-capybara (4.8.0)
12-
axe-core-api
13-
dumb_delegator
12+
axe-core-capybara (4.11.1)
13+
axe-core-api (= 4.11.1)
1414

1515
GEM
1616
remote: https://rubygems.org/
@@ -42,8 +42,13 @@ GEM
4242
language_server-protocol (3.17.0.3)
4343
matrix (0.4.2)
4444
mini_mime (1.1.5)
45+
mini_portile2 (2.8.9)
46+
nokogiri (1.15.5)
47+
mini_portile2 (~> 2.8.2)
48+
racc (~> 1.4)
4549
nokogiri (1.15.5-arm64-darwin)
4650
racc (~> 1.4)
51+
ostruct (0.6.3)
4752
parallel (1.23.0)
4853
parser (3.2.2.4)
4954
ast (~> 2.4.1)
@@ -104,6 +109,7 @@ GEM
104109

105110
PLATFORMS
106111
arm64-darwin-22
112+
x86_64-linux
107113

108114
DEPENDENCIES
109115
axe-core-api!
@@ -117,4 +123,4 @@ DEPENDENCIES
117123
selenium-webdriver
118124

119125
BUNDLED WITH
120-
2.4.10
126+
2.6.9

packages/axe-core-capybara/axe-core-capybara.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
2222
README.md
2323
]
2424

25-
spec.add_dependency "dumb_delegator"
2625
# pin to a specific version of axe-core-api
2726
spec.add_dependency "axe-core-api", AxeCoreGems::VERSION
2827

packages/axe-core-cucumber/Gemfile.lock

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
PATH
22
remote: ..
33
specs:
4-
axe-core-api (4.8.0)
4+
axe-core-api (4.11.1)
55
dumb_delegator
6+
ostruct
67
virtus
78

89
PATH
910
remote: .
1011
specs:
11-
axe-core-cucumber (4.8.0)
12-
axe-core-api
13-
dumb_delegator
14-
virtus
12+
axe-core-cucumber (4.11.1)
13+
axe-core-api (= 4.11.1)
1514

1615
GEM
1716
remote: https://rubygems.org/
@@ -58,6 +57,7 @@ GEM
5857
language_server-protocol (3.17.0.3)
5958
mini_mime (1.1.5)
6059
multi_test (1.1.0)
60+
ostruct (0.6.3)
6161
parallel (1.23.0)
6262
parser (3.2.2.4)
6363
ast (~> 2.4.1)
@@ -108,6 +108,7 @@ GEM
108108

109109
PLATFORMS
110110
arm64-darwin-22
111+
x86_64-linux
111112

112113
DEPENDENCIES
113114
axe-core-api!
@@ -120,4 +121,4 @@ DEPENDENCIES
120121
rubocop
121122

122123
BUNDLED WITH
123-
2.4.10
124+
2.6.9

packages/axe-core-cucumber/axe-core-cucumber.gemspec

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ Gem::Specification.new do |spec|
2222
README.md
2323
]
2424

25-
spec.add_dependency "dumb_delegator"
26-
# used by virtus; including it to make sure we install the gem and do not
27-
# rely on the standard library version, which will be removed in 3.5.0
28-
spec.add_dependency "ostruct"
29-
spec.add_dependency "virtus"
3025
# pin to a specific version of axe-core-api
3126
spec.add_dependency "axe-core-api", AxeCoreGems::VERSION
3227

packages/axe-core-rspec/Gemfile.lock

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
PATH
22
remote: ..
33
specs:
4-
axe-core-api (4.8.0)
4+
axe-core-api (4.11.1)
55
dumb_delegator
6+
ostruct
67
virtus
78

89
PATH
910
remote: .
1011
specs:
11-
axe-core-rspec (4.8.0)
12-
axe-core-api
13-
dumb_delegator
14-
virtus
12+
axe-core-rspec (4.11.1)
13+
axe-core-api (= 4.11.1)
1514

1615
GEM
1716
remote: https://rubygems.org/
@@ -30,6 +29,7 @@ GEM
3029
ice_nine (0.11.2)
3130
json (2.7.0)
3231
language_server-protocol (3.17.0.3)
32+
ostruct (0.6.3)
3333
parallel (1.23.0)
3434
parser (3.2.2.4)
3535
ast (~> 2.4.1)
@@ -78,6 +78,7 @@ GEM
7878

7979
PLATFORMS
8080
arm64-darwin-22
81+
x86_64-linux
8182

8283
DEPENDENCIES
8384
axe-core-api!
@@ -89,4 +90,4 @@ DEPENDENCIES
8990
rubocop
9091

9192
BUNDLED WITH
92-
2.4.10
93+
2.6.9

packages/axe-core-rspec/axe-core-rspec.gemspec

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ Gem::Specification.new do |spec|
2222
README.md
2323
]
2424

25-
spec.add_dependency "dumb_delegator"
26-
# used by virtus; including it to make sure we install the gem and do not
27-
# rely on the standard library version, which will be removed in 3.5.0
28-
spec.add_dependency "ostruct"
29-
spec.add_dependency "virtus"
3025
# pin to a specific version of axe-core-api
3126
spec.add_dependency "axe-core-api", AxeCoreGems::VERSION
3227

packages/axe-core-selenium/axe-core-selenium.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
2222
README.md
2323
]
2424

25-
spec.add_dependency "dumb_delegator"
2625
# pin to a specific version of axe-core-api
2726
spec.add_dependency "axe-core-api", AxeCoreGems::VERSION
2827

packages/axe-core-watir/axe-core-watir.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ Gem::Specification.new do |spec|
2222
README.md
2323
]
2424

25-
spec.add_dependency "dumb_delegator"
2625
# pin to a specific version of axe-core-api
2726
spec.add_dependency "axe-core-api", AxeCoreGems::VERSION
2827

0 commit comments

Comments
 (0)