cucumber-expressions: {word}-expression with unicode fix

[savkk]

Summary

• fix {word}-expression using Unicode characters.
• fix line separator in ExpressionExamplesTest.

Details

I think the summary is detailed enough :)

Motivation and Context

I have a problem when using {word}-expression with russian words.

How Has This Been Tested?

I've written unit-tests. An I'm testing it in my bdd-project.

Types of changes

• [x ] Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• [ x] I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[mpkorstanje]

Please ensure the examples.txt file has unix line endings and this shouldn't be needed.

[aslakhellesoy]

Looks good - I’ll merge this when the other implementations have a similar fix.

[savkk]

@mpkorstanje, I use Windows as default OS. And I've faced a problem when tried to run tests that were in your repo. I think Files.readAllBytes(Path p) adds line separator depending on the OS that it's executed on.
So I can't use unix line endings if I use Windows. I guess, it won't be convenient for other users too.

[savkk]

@aslakhellesoy, I don't really understand what exactly do you mean by "other implementations".

[aslakhellesoy]

JavaScript, Go and Ruby

[aslakhellesoy]

Hi @savkk,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[lsuski]

This broke cucumber on Android because of java.lang.IllegalArgumentException: Unsupported flags: 256. I'll check if can find workaround for this

[lsuski]

Although this flag exists in Android and docs says that it has no effect on Android but can be passed it is omitted in source code and passing it throws exception.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.