Skip to content

feat(init): add pnpm support#915

Merged
jimthedev merged 1 commit into
commitizen:masterfrom
chenaski:master
Jan 19, 2023
Merged

feat(init): add pnpm support#915
jimthedev merged 1 commit into
commitizen:masterfrom
chenaski:master

Conversation

@chenaski

@chenaski chenaski commented Mar 25, 2022

Copy link
Copy Markdown
Contributor

Added --pnpm option. For pnpm available --save, --save-dev and --save-exact options.

Resolves: #893, resolves #858, resolves #884.

pnpm reuses options available for npm, except `force`

re: #893, re #858
@huzedong2015

Copy link
Copy Markdown

How much longer will it take?

@chenaski

Copy link
Copy Markdown
Contributor Author

Are there any extra steps I should take?

@hellorayza

Copy link
Copy Markdown

Can anyone help?

@lisen6

lisen6 commented Jun 9, 2022

Copy link
Copy Markdown

Why doesn't mine work

@pulanski

Copy link
Copy Markdown

would love to see these changes added

1 similar comment
@jiamianmao

Copy link
Copy Markdown

would love to see these changes added

@mattyaodoit

Copy link
Copy Markdown

Keen to get this merged and support pnpm

@enrique-ramirez

Copy link
Copy Markdown

Any news on this?

@chenaski

chenaski commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

Does anyone know how everything works in this repo?

@HubooDeclan

Copy link
Copy Markdown

Can we get this merged?

@AmmarArnt

Copy link
Copy Markdown

Would love this PR merged too. Is this repo maintained?

@Ruobei

Ruobei commented Nov 29, 2022

Copy link
Copy Markdown

would love to see these changes added

@wangrongding

Copy link
Copy Markdown

Looking forward to this pr being merged. 👀

@jimthedev jimthedev merged commit c1f4142 into commitizen:master Jan 19, 2023
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jimthedev

Copy link
Copy Markdown
Member

It released but the tests are failing. So

  1. Build should not allow this.
  2. We may need to roll back or at least mark this as breaking and fix the tests.

@chenaski

Copy link
Copy Markdown
Contributor Author

I don't think there are any breaking changes, it seems I just forgot to update azure pipeline.
We need to add a pnpm installation before running the tests.

@Jalever

Jalever commented Aug 16, 2023

Copy link
Copy Markdown

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: add pnpm flag to the commitizen init flag Initialization error commitizen init doesn't work with pnpm