fix(Validation): correct required_without logic and prevent array key warnings

Author: gr8man

system/Validation/Rules.php

@@ -429,15 +429,22 @@ public function required_without(
 
                 $fieldData       = dot_array_search($otherField, $data);
                 $fieldSplitArray = explode('.', $field);
-                $fieldKey        = $fieldSplitArray[1];
+                $fieldKey        = $fieldSplitArray[1] ?? null;
 
                 if (is_array($fieldData)) {
-                    return ! empty(dot_array_search($otherField, $data)[$fieldKey]);
+                    if (empty($fieldData[$fieldKey])) {
+                        return false;
+                    }
+
+                    continue;
                 }
-                $nowField      = str_replace('*', $fieldKey, $otherField);
+
+                $nowField      = str_replace('*', (string) $fieldKey, $otherField);
                 $nowFieldVaule = dot_array_search($nowField, $data);
 
-                return null !== $nowFieldVaule;
+                if ($nowFieldVaule === null) {
+                    return false;
+                }
             }
         }
 

tests/system/Validation/ValidationTest.php

@@ -1854,6 +1854,51 @@ public function testRequireWithoutWithAsterisk(): void
         );
     }
 
+    /**
+     * Test that `required_without` checks all fields in dot-notation when there are multiple fields.
+     */
+    public function testRequireWithoutMultipleWithAsterisk(): void
+    {
+        $data = [
+            'a' => [
+                ['b' => 1, 'c' => 2, 'd' => ''],
+                ['b' => 1, 'c' => '', 'd' => ''],
+            ],
+        ];
+
+        $this->validation->setRules([
+            'a.*.d' => 'required_without[a.*.b,a.*.c]',
+        ])->run($data);
+
+        $this->assertSame(
+            'The a.*.d field is required when a.*.b,a.*.c is not present.',
+            $this->validation->getError('a.1.d'),
+        );
+    }
+
+    /**
+     * Test that `required_without` handles a non-asterisk field checked against an asterisk field
+     * without throwing undefined array key warnings for `$fieldSplitArray[1]`.
+     */
+    public function testRequireWithoutAsteriskOnNonAsteriskField(): void
+    {
+        $data = [
+            'foo' => '',
+            'a'   => [
+                ['b' => ''],
+            ],
+        ];
+
+        $this->validation->setRules([
+            'foo' => 'required_without[a.*.b]',
+        ])->run($data);
+
+        $this->assertSame(
+            'The foo field is required when a.*.b is not present.',
+            $this->validation->getError('foo'),
+        );
+    }
+
     /**
      * @see https://github.com/codeigniter4/CodeIgniter4/issues/8128
      */

user_guide_src/source/changelogs/v4.7.4.rst

@@ -41,6 +41,7 @@ Bugs Fixed
 - **Model:** Fixed a bug in ``Model::objectToRawArray()`` where the ``$recursive`` parameter was ignored.
 - **Session:** Fixed a bug in ``RedisHandler`` where the configured ``$lockMaxRetries`` and ``$lockRetryInterval`` values were not respected when acquiring session locks.
 - **Testing:** Fixed a bug where using ``MockInputOutput`` within a test that also uses ``StreamFilterTrait`` tore down the trait's stream filters, so CLI output produced after the ``MockInputOutput`` interaction (such as in ``tearDown()``) was no longer captured and leaked to the console.
+- **Validation:** Fixed bugs in the ``required_without`` rule logic where using array dot notation caused early exits ignoring subsequent fields and triggered an ``Undefined array key`` warning for missing keys.
 
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_