fix: address PR review feedback

- Replace z.coerce.number() with z.number() to prevent empty string → 0
- Tighten FormattedBodyMeasurement types from number | undefined | null to number | null
- Coalesce undefined to null in formatBodyMeasurement

Author: chrisdoc

src/tools/body-measurements.ts

@@ -18,7 +18,7 @@ type HevyClient = ReturnType<
 	typeof import("../utils/hevyClientKubb.js").createClient
 >;
 
-const zNullableNumber = z.coerce.number().nullable().optional();
+const zNullableNumber = z.number().nullable().optional();
 
 const bodyMeasurementFieldsSchema = {
 	weightKg: zNullableNumber.describe("Body weight in kilograms"),

src/utils/formatters.ts

@@ -297,46 +297,46 @@ export function formatExerciseHistoryEntry(
 
 export interface FormattedBodyMeasurement {
 	date: string;
-	weightKg: number | undefined | null;
-	leanMassKg: number | undefined | null;
-	fatPercent: number | undefined | null;
-	neckCm: number | undefined | null;
-	shoulderCm: number | undefined | null;
-	chestCm: number | undefined | null;
-	leftBicepCm: number | undefined | null;
-	rightBicepCm: number | undefined | null;
-	leftForearmCm: number | undefined | null;
-	rightForearmCm: number | undefined | null;
-	abdomen: number | undefined | null;
-	waist: number | undefined | null;
-	hips: number | undefined | null;
-	leftThigh: number | undefined | null;
-	rightThigh: number | undefined | null;
-	leftCalf: number | undefined | null;
-	rightCalf: number | undefined | null;
+	weightKg: number | null;
+	leanMassKg: number | null;
+	fatPercent: number | null;
+	neckCm: number | null;
+	shoulderCm: number | null;
+	chestCm: number | null;
+	leftBicepCm: number | null;
+	rightBicepCm: number | null;
+	leftForearmCm: number | null;
+	rightForearmCm: number | null;
+	abdomen: number | null;
+	waist: number | null;
+	hips: number | null;
+	leftThigh: number | null;
+	rightThigh: number | null;
+	leftCalf: number | null;
+	rightCalf: number | null;
 }
 
 export function formatBodyMeasurement(
 	measurement: BodyMeasurement,
 ): FormattedBodyMeasurement {
 	return {
 		date: measurement.date,
-		weightKg: measurement.weight_kg,
-		leanMassKg: measurement.lean_mass_kg,
-		fatPercent: measurement.fat_percent,
-		neckCm: measurement.neck_cm,
-		shoulderCm: measurement.shoulder_cm,
-		chestCm: measurement.chest_cm,
-		leftBicepCm: measurement.left_bicep_cm,
-		rightBicepCm: measurement.right_bicep_cm,
-		leftForearmCm: measurement.left_forearm_cm,
-		rightForearmCm: measurement.right_forearm_cm,
-		abdomen: measurement.abdomen,
-		waist: measurement.waist,
-		hips: measurement.hips,
-		leftThigh: measurement.left_thigh,
-		rightThigh: measurement.right_thigh,
-		leftCalf: measurement.left_calf,
-		rightCalf: measurement.right_calf,
+		weightKg: measurement.weight_kg ?? null,
+		leanMassKg: measurement.lean_mass_kg ?? null,
+		fatPercent: measurement.fat_percent ?? null,
+		neckCm: measurement.neck_cm ?? null,
+		shoulderCm: measurement.shoulder_cm ?? null,
+		chestCm: measurement.chest_cm ?? null,
+		leftBicepCm: measurement.left_bicep_cm ?? null,
+		rightBicepCm: measurement.right_bicep_cm ?? null,
+		leftForearmCm: measurement.left_forearm_cm ?? null,
+		rightForearmCm: measurement.right_forearm_cm ?? null,
+		abdomen: measurement.abdomen ?? null,
+		waist: measurement.waist ?? null,
+		hips: measurement.hips ?? null,
+		leftThigh: measurement.left_thigh ?? null,
+		rightThigh: measurement.right_thigh ?? null,
+		leftCalf: measurement.left_calf ?? null,
+		rightCalf: measurement.right_calf ?? null,
 	};
 }