Skip to content

Commit 241c9dd

Browse files
CEL Dev Teamcopybara-github
authored andcommitted
Improve error messages for Value type casting errors.
PiperOrigin-RevId: 698874247
1 parent d50f3d3 commit 241c9dd

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

eval/public/structs/proto_message_type_adapter.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,9 @@ absl::Status ProtoMessageTypeAdapter::SetField(
561561
const CelMap* cel_map;
562562
CEL_RETURN_IF_ERROR(ValidateSetFieldOp(
563563
value.GetValue<const CelMap*>(&cel_map) && cel_map != nullptr,
564-
field->name(), "value is not CelMap"));
564+
field->name(),
565+
absl::StrCat("value is not CelMap - value is ",
566+
CelValue::TypeName(value.type()))));
565567

566568
auto entry_descriptor = field->message_type();
567569

@@ -598,7 +600,9 @@ absl::Status ProtoMessageTypeAdapter::SetField(
598600
const CelList* cel_list;
599601
CEL_RETURN_IF_ERROR(ValidateSetFieldOp(
600602
value.GetValue<const CelList*>(&cel_list) && cel_list != nullptr,
601-
field->name(), "expected CelList value"));
603+
field->name(),
604+
absl::StrCat("expected CelList value - value is",
605+
CelValue::TypeName(value.type()))));
602606

603607
for (int i = 0; i < cel_list->size(); i++) {
604608
CEL_RETURN_IF_ERROR(internal::AddValueToRepeatedField(

0 commit comments

Comments
 (0)