Skip to content

Commit fd0de60

Browse files
committed
refactor: 优化 SimpleRes 工具类
1 parent 494e9a5 commit fd0de60

3 files changed

Lines changed: 23 additions & 22 deletions

File tree

simple-common/src/main/java/top/cadecode/common/exception/SimpleExceptionHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class SimpleExceptionHandler extends DefaultErrorAttributes {
3131
*/
3232
@ExceptionHandler(SimpleException.class)
3333
@ResponseBody
34-
public SimpleRes<?> handleSimpleException(SimpleException e, HttpServletRequest request) {
34+
public SimpleRes<Object> handleSimpleException(SimpleException e, HttpServletRequest request) {
3535
log.error("SimpleException Handler =>", e);
3636
return SimpleRes.of(e.getResCode())
3737
.errorMsg(e.getMessage())
@@ -43,7 +43,7 @@ public SimpleRes<?> handleSimpleException(SimpleException e, HttpServletRequest
4343
*/
4444
@ExceptionHandler(Exception.class)
4545
@ResponseBody
46-
public SimpleRes<?> handleOtherException(Exception e, HttpServletRequest request) {
46+
public SimpleRes<Object> handleOtherException(Exception e, HttpServletRequest request) {
4747
// 获取请求路径
4848
String requestURI = request.getRequestURI();
4949
log.error("Exception Handler =>", e);

simple-common/src/main/java/top/cadecode/common/response/SimpleRes.java

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -20,25 +20,21 @@ public class SimpleRes<T> {
2020
private Integer code;
2121
private String reason;
2222
private String path;
23+
24+
// 设置为 null 时不序列化
2325
@JsonInclude(Include.NON_NULL)
2426
private T data;
2527
@JsonInclude(Include.NON_NULL)
2628
private String errorMsg;
2729

2830
/**
29-
* 返回成功的响应
31+
* 根据 data 返回成功的响应
3032
*
3133
* @param data
3234
* @return SimpleRes
3335
*/
3436
public static <T> SimpleRes<T> ok(T data) {
35-
SimpleRes<T> res = new SimpleRes<>();
36-
ResCode success = ResCode.SUCCESS;
37-
res.setCode(success.getCode());
38-
res.setReason(success.getReason());
39-
res.setData(data);
40-
return res;
41-
37+
return SimpleRes.of(ResCode.SUCCESS, data);
4238
}
4339

4440
/**
@@ -47,35 +43,40 @@ public static <T> SimpleRes<T> ok(T data) {
4743
* @param resCode
4844
* @return SimpleRes
4945
*/
50-
public static SimpleRes<?> of(ResCode resCode) {
51-
SimpleRes<?> res = new SimpleRes<>();
46+
public static SimpleRes<Object> of(ResCode resCode) {
47+
SimpleRes<Object> res = new SimpleRes<>();
5248
res.setCode(resCode.getCode());
5349
res.setReason(resCode.getReason());
5450
return res;
5551
}
5652

5753
/**
58-
* 设置 path
54+
* 根据 ResCode 和 data 返回响应
5955
*
60-
* @param path
56+
* @param resCode
57+
* @param data
6158
* @return SimpleRes
6259
*/
63-
public SimpleRes<T> path(String path) {
64-
this.setPath(path);
65-
return this;
60+
public static <T> SimpleRes<T> of(ResCode resCode, T data) {
61+
SimpleRes<T> res = new SimpleRes<>();
62+
res.setCode(resCode.getCode());
63+
res.setReason(resCode.getReason());
64+
res.setData(data);
65+
return res;
6666
}
6767

6868
/**
69-
* 设置 data
69+
* 设置 path
7070
*
71-
* @param data
71+
* @param path
7272
* @return SimpleRes
7373
*/
74-
public SimpleRes<T> data(T data) {
75-
this.setData(data);
74+
public SimpleRes<T> path(String path) {
75+
this.setPath(path);
7676
return this;
7777
}
7878

79+
7980
/**
8081
* 设置 data
8182
*

simple-common/src/test/java/top/cadecode/common/response/SimpleResTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public void ok() {
2121
}
2222

2323
@Test
24-
public void fail() {
24+
public void of() {
2525
String failJson = JsonUtil.objToStr(SimpleRes.of(ResCode.UNKNOWN),
2626
true);
2727
log.info("failJson: {}", failJson);

0 commit comments

Comments
 (0)