Commit 0c13e59
committed
docs(awssm): grant BatchGetSecretValue on "*", not a secret ARN
The documented IAM policy put secretsmanager:BatchGetSecretValue in a
statement scoped to arn:aws:secretsmanager:*:*:secret:secretspec/*. AWS
treats it as an account-level action that takes no resource, so a
resource-scoped statement never grants it.
get_many() batches through BatchGetSecretValue (awssm.rs:330, reached from
secrets.rs:2346), and that is the path check and run resolve through — so
anyone copying the policy hit AccessDeniedException on the two most common
commands.
Split into two statements: the batch action on "*", everything else still
scoped to the secretspec prefix. ListSecrets is deliberately not added; the
provider addresses secrets with secret_id_list rather than filters, and only
the filter form requires it.
The note now says why "*" is required and, since granting anything on "*"
invites a second look, why it does not widen access: AWS still requires
GetSecretValue for every secret a batch returns, and that stays ARN-scoped.
Closes #3421 parent 4b8ae3e commit 0c13e59
1 file changed
Lines changed: 20 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
59 | | - | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
64 | 70 | | |
65 | 71 | | |
66 | 72 | | |
67 | 73 | | |
68 | 74 | | |
69 | | - | |
| 75 | + | |
| 76 | + | |
70 | 77 | | |
71 | 78 | | |
72 | 79 | | |
73 | 80 | | |
74 | 81 | | |
75 | 82 | | |
76 | | - | |
77 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
78 | 94 | | |
79 | 95 | | |
80 | 96 | | |
| |||
0 commit comments