fix: dedupe socket aliases to stop duplicate panes

Author: bma-d

docs/changelog/260305.md

@@ -0,0 +1,23 @@
+# Changelog - 260305
+
+## 260305-01:36:39 - Prevent duplicate pane rendering from socket alias paths
+
+### Summary
+Canonicalized socket identity so the same tmux server is not discovered twice via symlinked path aliases.
+
+### Changed
+- Added symlink-aware socket path canonicalization for socket identity keys.
+- Updated socket discovery dedupe to compare canonical path keys instead of raw path strings.
+- Added regression test covering two alias paths pointing to the same socket file.
+
+### Fixed
+- Fixed duplicate pane/session rendering when both `/tmp/...sock` and `/private/tmp/...sock` resolve to the same socket.
+
+### Files
+- `src/sockets.go`
+- `src/socket_test.go`
+
+### QA Notes
+- Verify panes are shown once when Lisa socket exists under both `/tmp` and `/private/tmp`.
+- Verify socket discovery still includes distinct sockets.
+- Verify regression suite passes: `go test ./src/...`.

src/socket_test.go

@@ -506,6 +506,37 @@ func TestLisaSocketGlobsCustomOverridesFallbacks(t *testing.T) {
 	}
 }
 
+func TestDiscoverSocketTargetsDedupesSymlinkedSocketAliases(t *testing.T) {
+	t.Setenv("TMUX", "")
+	stubLisaSockets(t, []string{}, nil)
+
+	realDir := t.TempDir()
+	linkDir := filepath.Join(t.TempDir(), "alias")
+	if err := os.Symlink(realDir, linkDir); err != nil {
+		t.Skipf("symlink unsupported: %v", err)
+	}
+
+	socketName := "same.sock"
+	realSocket := filepath.Join(realDir, socketName)
+	aliasSocket := filepath.Join(linkDir, socketName)
+	if err := os.WriteFile(realSocket, []byte("x"), 0o600); err != nil {
+		t.Fatalf("write real socket: %v", err)
+	}
+
+	cfg := config{
+		includeDefaultSocket: false,
+		includeLisaSockets:   false,
+		explicitSockets:      []string{realSocket, aliasSocket},
+	}
+	targets, discoveryErrors := discoverSocketTargets(cfg)
+	if len(discoveryErrors) != 0 {
+		t.Fatalf("unexpected discoveryErrors: %v", discoveryErrors)
+	}
+	if len(targets) != 1 {
+		t.Fatalf("targets len = %d, targets=%v", len(targets), targets)
+	}
+}
+
 func containsString(items []string, needle string) bool {
 	for _, item := range items {
 		if item == needle {

src/sockets.go

@@ -179,15 +179,35 @@ func dedupePaths(paths []string) []string {
 		if clean == "" || clean == "." {
 			continue
 		}
-		if _, ok := seen[clean]; ok {
+		key := canonicalSocketPathKey(clean)
+		if key == "" {
+			key = clean
+		}
+		if _, ok := seen[key]; ok {
 			continue
 		}
-		seen[clean] = struct{}{}
+		seen[key] = struct{}{}
 		out = append(out, clean)
 	}
 	return out
 }
 
+func canonicalSocketPathKey(path string) string {
+	clean := filepath.Clean(strings.TrimSpace(path))
+	if clean == "" || clean == "." {
+		return ""
+	}
+	resolved, err := filepath.EvalSymlinks(clean)
+	if err != nil {
+		return clean
+	}
+	resolved = filepath.Clean(strings.TrimSpace(resolved))
+	if resolved == "" || resolved == "." {
+		return clean
+	}
+	return resolved
+}
+
 func listLisaSocketPathsFromProcessTable() ([]string, error) {
 	commands, err := listProcessCommandsFn()
 	if err != nil {
@@ -415,7 +435,7 @@ func socketKey(path string) string {
 	if strings.TrimSpace(path) == "" {
 		return defaultSocketKey
 	}
-	return filepath.Clean(path)
+	return canonicalSocketPathKey(path)
 }
 
 func socketHint(path string) string {