Commit ce34e5d
committed
feat(huddle): add 'headphones recommended' banner while AEC is missing
Adds a session-dismissable banner inside HuddleBar that warns users to use
headphones until echo cancellation lands. Lives in a new tiny
HeadphonesNotice component so it can be deleted in one diff when the AEC
follow-up PR flips aecMissing to false.
Why it's needed for this PR: the FIFO/jitter fix in commit 25b380f and
the protocol v2 frame header in commit b6dd829 together make 10-person
huddles work *for everyone wearing headphones*. The play path is still
native rodio (outside the WebView render graph), so the browser's WebRTC
echo canceller has nothing to cancel against. Two users on speakers in
the same physical room would hear themselves echo. The banner makes
that limitation visible up-front rather than letting users discover it
when they're already in a 10-person meeting.
Quinn's tripwire from the design thread: AEC v1 is the next PR after
this one merges, not 'soon' or 'in the backlog'.
Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>1 parent b6dd829 commit ce34e5d
2 files changed
Lines changed: 64 additions & 0 deletions
Lines changed: 40 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
60 | 61 | | |
61 | 62 | | |
62 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
63 | 74 | | |
64 | 75 | | |
65 | 76 | | |
| |||
165 | 176 | | |
166 | 177 | | |
167 | 178 | | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
168 | 185 | | |
169 | 186 | | |
170 | 187 | | |
| |||
226 | 243 | | |
227 | 244 | | |
228 | 245 | | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
229 | 253 | | |
230 | 254 | | |
231 | 255 | | |
| |||
0 commit comments