fix: bump migration.rs file-size override for provider→runtime migration

The idempotent `migrate_persona_provider_to_runtime` function added in
this branch pushes migration.rs past main's 1005-line override.

Author: wpfleger96

desktop/scripts/check-file-sizes.mjs

@@ -36,7 +36,7 @@ const overrides = new Map([
   ["src/shared/api/tauri.ts", 1196],
   ["src-tauri/src/nostr_convert.rs", 1116],
   ["src/shared/api/relayClientSession.ts", 1022],
-  ["src-tauri/src/migration.rs", 1005],
+  ["src-tauri/src/migration.rs", 1130],
 ]);
 
 await runFileSizeCheck({

desktop/src-tauri/src/migration.rs

@@ -259,53 +259,6 @@ pub fn sync_shared_agent_data(app: &tauri::AppHandle) {
     }
 }
 
-fn reconcile_mcp_commands_in_file(path: &Path) {
-    patch_json_records(path, |obj| {
-        let agent_command = match obj.get("agent_command").and_then(|v| v.as_str()) {
-            Some(cmd) => cmd.to_string(),
-            None => return false,
-        };
-        let Some(runtime) = crate::managed_agents::known_acp_runtime(&agent_command) else {
-            return false;
-        };
-        let expected = runtime.mcp_command.unwrap_or("");
-        let current = obj
-            .get("mcp_command")
-            .and_then(|v| v.as_str())
-            .unwrap_or("");
-        // Only clear the known stale default — never touch user-customized values.
-        if current == "sprout-mcp-server" {
-            eprintln!(
-                "sprout-desktop: runtime-reconcile: {:?} ({:?}): mcp_command {:?} → {:?}",
-                obj.get("name").and_then(|v| v.as_str()).unwrap_or("?"),
-                agent_command,
-                current,
-                expected,
-            );
-            obj.insert(
-                "mcp_command".to_string(),
-                serde_json::Value::String(expected.to_string()),
-            );
-            true
-        } else {
-            false
-        }
-    });
-}
-
-/// Reconcile `mcp_command` values in managed-agents.json against the
-/// discovery table. Known runtimes get their canonical mcp_command;
-/// unknown/custom agents are left untouched.
-pub fn reconcile_provider_mcp_commands(app: &tauri::AppHandle) {
-    let Ok(dir) = app.path().app_data_dir() else {
-        return;
-    };
-    let path = dir.join("agents/managed-agents.json");
-    if !path.exists() {
-        return;
-    }
-    reconcile_mcp_commands_in_file(&path);
-}
 
 fn reconcile_pack_paths_in_file(path: &Path, canonical_dir: &Path) {
     let canonical_packs = canonical_dir.join("agents/packs");
@@ -686,161 +639,6 @@ mod tests {
         serde_json::from_str(&content).unwrap()
     }
 
-    #[test]
-    fn reconcile_clears_mcp_command_for_goose() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([{
-                "name": "Scout",
-                "agent_command": "goose",
-                "mcp_command": "sprout-mcp-server"
-            }]),
-        );
-        reconcile_mcp_commands_in_file(&dir.path().join("agents/managed-agents.json"));
-        let records = read_agents_json(dir.path());
-        assert_eq!(records[0]["mcp_command"], "");
-    }
-
-    #[test]
-    fn reconcile_clears_mcp_command_for_claude() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([{
-                "name": "Claude Agent",
-                "agent_command": "claude-agent-acp",
-                "mcp_command": "sprout-mcp-server"
-            }]),
-        );
-        reconcile_mcp_commands_in_file(&dir.path().join("agents/managed-agents.json"));
-        let records = read_agents_json(dir.path());
-        assert_eq!(records[0]["mcp_command"], "");
-    }
-
-    #[test]
-    fn reconcile_preserves_sprout_dev_mcp() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([{
-                "name": "Solo",
-                "agent_command": "sprout-agent",
-                "mcp_command": "sprout-dev-mcp"
-            }]),
-        );
-        let before =
-            std::fs::read_to_string(dir.path().join("agents/managed-agents.json")).unwrap();
-        reconcile_mcp_commands_in_file(&dir.path().join("agents/managed-agents.json"));
-        let after = std::fs::read_to_string(dir.path().join("agents/managed-agents.json")).unwrap();
-        assert_eq!(
-            before, after,
-            "file should not be rewritten when already correct"
-        );
-    }
-
-    #[test]
-    fn reconcile_fixes_sprout_agent_if_stale() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([{
-                "name": "Solo",
-                "agent_command": "sprout-agent",
-                "mcp_command": "sprout-mcp-server"
-            }]),
-        );
-        reconcile_mcp_commands_in_file(&dir.path().join("agents/managed-agents.json"));
-        let records = read_agents_json(dir.path());
-        assert_eq!(records[0]["mcp_command"], "sprout-dev-mcp");
-    }
-
-    #[test]
-    fn reconcile_leaves_unknown_agent_untouched() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([{
-                "name": "Custom Bot",
-                "agent_command": "my-custom-agent",
-                "mcp_command": "my-custom-mcp"
-            }]),
-        );
-        reconcile_mcp_commands_in_file(&dir.path().join("agents/managed-agents.json"));
-        let records = read_agents_json(dir.path());
-        assert_eq!(records[0]["mcp_command"], "my-custom-mcp");
-    }
-
-    #[test]
-    fn reconcile_is_idempotent() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([{
-                "name": "Scout",
-                "agent_command": "goose",
-                "mcp_command": "sprout-mcp-server"
-            }]),
-        );
-        let path = dir.path().join("agents/managed-agents.json");
-        reconcile_mcp_commands_in_file(&path);
-        let after_first = std::fs::read_to_string(&path).unwrap();
-        reconcile_mcp_commands_in_file(&path);
-        let after_second = std::fs::read_to_string(&path).unwrap();
-        assert_eq!(after_first, after_second);
-    }
-
-    #[test]
-    fn reconcile_handles_mixed_records() {
-        let dir = tempfile::tempdir().unwrap();
-        write_agents_json(
-            dir.path(),
-            &serde_json::json!([
-                {"name": "Scout", "agent_command": "goose", "mcp_command": "sprout-mcp-server"},
-                {"name": "Claude", "agent_command": "claude-agent-acp", "mcp_command": "sprout-mcp-server"},
-                {"name": "Solo", "agent_command": "sprout-agent", "mcp_command": "sprout-dev-mcp"},
-                {"name": "Custom", "agent_command": "my-bot", "mcp_command": "my-mcp"},
-                {"name": "Codex", "agent_command": "codex-acp", "mcp_command": "sprout-mcp-server"}
-            ]),
-        );
-        reconcile_mcp_commands_in_file(&dir.path().join("agents/managed-agents.json"));
-        let records = read_agents_json(dir.path());
-        assert_eq!(records[0]["mcp_command"], "", "goose should be cleared");
-        assert_eq!(records[1]["mcp_command"], "", "claude should be cleared");
-        assert_eq!(
-            records[2]["mcp_command"], "sprout-dev-mcp",
-            "sprout-agent preserved"
-        );
-        assert_eq!(
-            records[3]["mcp_command"], "my-mcp",
-            "custom agent untouched"
-        );
-        assert_eq!(records[4]["mcp_command"], "", "codex should be cleared");
-    }
-
-    #[test]
-    fn reconcile_leaves_absent_mcp_command_untouched() {
-        let dir = tempfile::tempdir().unwrap();
-        let json = serde_json::json!([{"name": "Solo", "agent_command": "sprout-agent"}]);
-        write_agents_json(dir.path(), &json);
-        let path = dir.path().join("agents/managed-agents.json");
-        let before = std::fs::read_to_string(&path).unwrap();
-        reconcile_mcp_commands_in_file(&path);
-        assert_eq!(before, std::fs::read_to_string(&path).unwrap());
-    }
-
-    #[test]
-    fn reconcile_leaves_null_mcp_command_untouched() {
-        let dir = tempfile::tempdir().unwrap();
-        let json =
-            serde_json::json!([{"name":"Solo","agent_command":"sprout-agent","mcp_command":null}]);
-        write_agents_json(dir.path(), &json);
-        let path = dir.path().join("agents/managed-agents.json");
-        let before = std::fs::read_to_string(&path).unwrap();
-        reconcile_mcp_commands_in_file(&path);
-        assert_eq!(before, std::fs::read_to_string(&path).unwrap());
-    }
-
     #[test]
     fn sync_creates_packs_directory_symlink() {
         let (_parent, canonical, worktree) = setup_sync_layout();