fix(css): validate @Property syntax descriptors (#11175)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: ematipico

.changeset/yummy-owls-boil.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed CSS parsing of registered custom properties: Biome now correctly validates the `syntax` descriptor of `@property` rules.

Cargo.lock

@@ -8,6 +8,7 @@ use biome_analyze_macros::RuleSourceVariantIndex;
 use biome_console::fmt::{Display, Formatter};
 use biome_console::{MarkupBuf, markup};
 use biome_diagnostics::location::AsSpan;
+use biome_diagnostics::serde::Advices as SerializableAdvices;
 use biome_diagnostics::{
     Advices, Category, Diagnostic, DiagnosticTags, Location, LogCategory, MessageAndDescription,
     Visit,
@@ -1611,6 +1612,10 @@ impl Advices for RuleDiagnostic {
             visitor.record_list(&list)?;
         }
 
+        for advices in &self.rule_advice.parent_advices {
+            advices.record(visitor)?;
+        }
+
         Ok(())
     }
 }
@@ -1621,6 +1626,8 @@ pub struct RuleAdvice {
     pub(crate) details: Vec<Detail>,
     pub(crate) notes: Vec<(LogCategory, MarkupBuf)>,
     pub(crate) suggestion_list: Option<SuggestionList>,
+    /// Advices provided by other diagnostics
+    pub(crate) parent_advices: Vec<SerializableAdvices>,
 }
 
 #[derive(Clone, Debug, Default)]
@@ -1655,6 +1662,9 @@ impl RuleDiagnostic {
 
     pub(crate) fn set_advice_offset(&mut self, offset: TextSize) {
         self.advice_offset = Some(offset);
+        for advices in &mut self.rule_advice.parent_advices {
+            advices.offset_by(offset);
+        }
     }
 
     /// Marks this diagnostic as deprecated code, which will
@@ -1713,6 +1723,14 @@ impl RuleDiagnostic {
         self.footer(LogCategory::Info, msg)
     }
 
+    /// Attaches advice emitted by `advices`.
+    pub fn with_advices(mut self, advices: impl Advices) -> Self {
+        self.rule_advice
+            .parent_advices
+            .push(SerializableAdvices::new(&advices));
+        self
+    }
+
     /// It creates a new footer note which contains a message and a list of possible suggestions.
     /// Useful when there's need to suggest a list of things inside a diagnostic.
     pub fn footer_list(

crates/biome_analyze/src/rule.rs

@@ -2712,6 +2712,38 @@ fn lint_syntax_rules() {
     ));
 }
 
+#[test]
+fn lint_invalid_property_syntax() {
+    let fs = MemoryFileSystem::default();
+    let mut console = BufferConsole::default();
+
+    let file_path = Utf8Path::new("check.css");
+    fs.insert(
+        file_path.into(),
+        r#"@property --value {
+    syntax: "<unknown>";
+    inherits: false;
+}"#
+        .as_bytes(),
+    );
+
+    let (fs, result) = run_cli(
+        fs,
+        &mut console,
+        Args::from(["lint", file_path.as_str()].as_slice()),
+    );
+
+    assert!(result.is_err(), "run_cli returned {result:?}");
+
+    assert_cli_snapshot(SnapshotPayload::new(
+        module_path!(),
+        "lint_invalid_property_syntax",
+        fs,
+        console,
+        result,
+    ));
+}
+
 #[test]
 fn should_lint_error_without_file_paths() {
     let fs = MemoryFileSystem::default();

crates/biome_cli/tests/commands/lint.rs

@@ -0,0 +1,62 @@
+---
+source: crates/biome_cli/tests/snap_test.rs
+expression: redactor(content)
+---
+## `check.css`
+
+```css
+@property --value {
+  syntax: "<unknown>";
+  inherits: false;
+}
+```
+
+# Termination Message
+
+```block
+lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Some errors were emitted while running checks.
+  
+
+
+```
+
+# Emitted Messages
+
+```block
+check.css:2:14 syntax/correctness/noInvalidPropertySyntax ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  × Use a supported property syntax type.
+  
+    1 │ @property --value {
+  > 2 │     syntax: "<unknown>";
+      │              ^^^^^^^^^
+    3 │     inherits: false;
+    4 │ }
+  
+  i Supported types:
+  
+  - <angle>
+  - <color>
+  - <custom-ident>
+  - <image>
+  - <integer>
+  - <length>
+  - <length-percentage>
+  - <number>
+  - <percentage>
+  - <resolution>
+  - <string>
+  - <time>
+  - <transform-function>
+  - <transform-list>
+  - <url>
+  
+
+```
+
+```block
+Checked 1 file in <TIME>. No fixes applied.
+Found 1 error.
+```

crates/biome_cli/tests/snapshots/main_commands_lint/lint_invalid_property_syntax.snap

@@ -31,6 +31,7 @@ biome_diagnostics        = { workspace = true }
 biome_languages          = { workspace = true, features = ["lang_css"] }
 biome_module_graph       = { workspace = true }
 biome_project_layout     = { workspace = true }
+biome_property_codec     = { workspace = true }
 biome_rowan              = { workspace = true }
 biome_rule_options       = { workspace = true }
 biome_string_case        = { workspace = true }

crates/biome_css_analyze/Cargo.toml

@@ -20,6 +20,7 @@ fn main() -> io::Result<()> {
     watch_group("lint", "nursery")?;
     watch_group("lint", "style")?;
     watch_group("lint", "suspicious")?;
+    watch_group("syntax", "correctness")?;
     Ok(())
 }
 #[doc = r" Watch a specific group directory and touch its group file when changes occur"]

crates/biome_css_analyze/build.rs

@@ -9,6 +9,7 @@ mod order;
 mod registry;
 mod services;
 mod suppression_action;
+mod syntax;
 mod utils;
 
 pub use crate::registry::visit_registry;
@@ -175,10 +176,7 @@ where
 
     services.insert_service(css_services.file_source);
     if let Some(semantic_model) = css_services.semantic_model {
-        services.insert_service(Arc::new(semantic_model.clone()));
-    } else {
-        let semantic_model = biome_css_semantic::semantic_model(root);
-        services.insert_service(Arc::new(semantic_model));
+        services.insert_service(semantic_model.clone());
     }
     if let Some(module_db) = css_services.module_db {
         services.insert_service(module_db);
@@ -314,7 +312,7 @@ mod tests {
     fn top_level_suppression_simple() {
         const SOURCE: &str = "
 /**
-* biome-ignore lint/suspicious/noEmptyBlock: reason
+ * biome-ignore-all lint/suspicious/noEmptyBlock: reason
 */
 
 #foo {}
@@ -324,7 +322,8 @@ mod tests {
         let parsed = parse_css(SOURCE, CssFileSource::css(), CssParserOptions::default());
 
         let filter = AnalysisFilter {
-            categories: RuleCategoriesBuilder::default().with_syntax().build(),
+            categories: RuleCategoriesBuilder::default().with_lint().build(),
+            enabled_rules: Some(&[RuleFilter::Rule("suspicious", "noEmptyBlock")]),
             ..AnalysisFilter::default()
         };
 
@@ -359,11 +358,11 @@ mod tests {
     fn top_level_suppression_multiple() {
         const SOURCE: &str = "
 /**
-* biome-ignore lint/suspicious/noEmptyBlock: reason
+ * biome-ignore-all lint/suspicious/noEmptyBlock: reason
 */
 
 /**
-* biome-ignore lint/correctness/noUnknownProperty: reason2
+ * biome-ignore-all lint/correctness/noUnknownProperty: reason2
 */
 
 
@@ -376,7 +375,11 @@ a {
         let parsed = parse_css(SOURCE, CssFileSource::css(), CssParserOptions::default());
 
         let filter = AnalysisFilter {
-            categories: RuleCategoriesBuilder::default().with_syntax().build(),
+            categories: RuleCategoriesBuilder::default().with_lint().build(),
+            enabled_rules: Some(&[
+                RuleFilter::Rule("suspicious", "noEmptyBlock"),
+                RuleFilter::Rule("correctness", "noUnknownProperty"),
+            ]),
             ..AnalysisFilter::default()
         };
 
@@ -411,8 +414,8 @@ a {
     fn top_level_suppression_multiple2() {
         const SOURCE: &str = "
 /**
-* biome-ignore lint/suspicious/noEmptyBlock: reason
-* biome-ignore lint/correctness/noUnknownProperty: reason2
+ * biome-ignore-all lint/suspicious/noEmptyBlock: reason
+ * biome-ignore-all lint/correctness/noUnknownProperty: reason2
 */
 
 #foo {}
@@ -424,7 +427,11 @@ a {
         let parsed = parse_css(SOURCE, CssFileSource::css(), CssParserOptions::default());
 
         let filter = AnalysisFilter {
-            categories: RuleCategoriesBuilder::default().with_syntax().build(),
+            categories: RuleCategoriesBuilder::default().with_lint().build(),
+            enabled_rules: Some(&[
+                RuleFilter::Rule("suspicious", "noEmptyBlock"),
+                RuleFilter::Rule("correctness", "noUnknownProperty"),
+            ]),
             ..AnalysisFilter::default()
         };
 
@@ -458,18 +465,16 @@ a {
     #[test]
     fn top_level_suppression_with_unused() {
         const SOURCE: &str = "
-/**
-*/
-
-#foo {}
+#foo { color: red; }
 // biome-ignore lint/suspicious/noEmptyBlock: reason
-#bar {}
+#bar { color: blue; }
         ";
 
         let parsed = parse_css(SOURCE, CssFileSource::css(), CssParserOptions::default());
 
         let filter = AnalysisFilter {
-            categories: RuleCategoriesBuilder::default().with_syntax().build(),
+            categories: RuleCategoriesBuilder::default().with_lint().build(),
+            enabled_rules: Some(&[RuleFilter::Rule("suspicious", "noEmptyBlock")]),
             ..AnalysisFilter::default()
         };