feat: noRestrictedDependencies (#10467)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

Author: 3 people

.changeset/modern-lands-find.md

@@ -0,0 +1,19 @@
+---
+"@biomejs/biome": patch
+---
+
+Added a new nursery rule [`noRestrictedDependencies`](https://biomejs.dev/linter/rules/no-restricted-dependencies/), which flags imports and `package.json` dependency entries that have better alternatives in e18e's module replacement data.
+
+For example, the package `globby` is reported because there's a better alternative:
+
+```js
+import glob from "globby"
+```
+
+```json
+{
+  "dependencies": {
+    "globby": "x.x.x"
+  }
+}
+```

.gitattributes

@@ -19,6 +19,7 @@
 /crates/biome_css_analyze/src/{lint,assist,syntax}/*.rs linguist-generated=true text=auto eol=lf
 /crates/biome_css_analyze/src/options.rs linguist-generated=true text=auto eol=lf
 /crates/biome_css_analyze/src/registry.rs linguist-generated=true text=auto eol=lf
+/crates/biome_css_analyze/src/baseline_data.rs linguist-generated=true text=auto eol=lf
 # JSON
 /crates/biome_json_formatter/src/json/any/*.rs linguist-generated=true text=auto eol=lf
 /crates/biome_json_analyze/src/{lint,assist,syntax}.rs linguist-generated=true text=auto eol=lf

Cargo.lock

@@ -83,6 +83,7 @@ biome_markdown_syntax        = { path = "./crates/biome_markdown_syntax", versio
 biome_markup                 = { path = "./crates/biome_markup", version = "0.5.7" }
 biome_migrate                = { path = "./crates/biome_migrate" }
 biome_module_graph           = { path = "./crates/biome_module_graph", version = "0.0.1" }
+biome_module_replacements    = { path = "./crates/biome_module_replacements", version = "0.5.7" }
 biome_package                = { path = "./crates/biome_package", version = "0.5.7" }
 biome_parser                 = { path = "./crates/biome_parser", version = "0.5.7" }
 biome_plugin_loader          = { path = "./crates/biome_plugin_loader", version = "0.0.1" }

Cargo.toml

@@ -20,44 +20,45 @@ harness = false
 name    = "use_sorted_classes_parser"
 
 [dependencies]
-biome_analyze            = { workspace = true }
-biome_analyze_macros     = { workspace = true }
-biome_aria               = { workspace = true }
-biome_aria_metadata      = { workspace = true }
-biome_console            = { workspace = true }
-biome_control_flow       = { workspace = true }
-biome_deserialize        = { workspace = true, features = ["smallvec"] }
-biome_deserialize_macros = { workspace = true }
-biome_diagnostics        = { workspace = true }
-biome_fs                 = { workspace = true }
-biome_glob               = { workspace = true, features = ["biome_deserialize", "serde"] }
-biome_js_factory         = { workspace = true }
-biome_js_semantic        = { workspace = true }
-biome_js_syntax          = { workspace = true }
-biome_js_type_info       = { workspace = true }
-biome_jsdoc_comment      = { workspace = true }
-biome_module_graph       = { workspace = true }
-biome_package            = { workspace = true }
-biome_project_layout     = { workspace = true }
-biome_resolver           = { workspace = true }
-biome_rowan              = { workspace = true }
-biome_rule_options       = { workspace = true }
-biome_string_case        = { workspace = true, features = ["biome_rowan"] }
-biome_suppression        = { workspace = true }
-biome_tailwind_parser    = { workspace = true }
-biome_tailwind_syntax    = { workspace = true }
-biome_unicode_table      = { workspace = true }
-bitvec                   = "1.0.1"
-camino                   = { workspace = true }
-enumflags2               = { workspace = true }
-globset                  = { workspace = true }
-phf                      = { workspace = true }
-regex                    = { workspace = true }
-roaring                  = "0.11.3"
-rustc-hash               = { workspace = true }
-schemars                 = { workspace = true, optional = true }
-serde                    = { workspace = true, features = ["derive"] }
-smallvec                 = { workspace = true }
+biome_analyze             = { workspace = true }
+biome_analyze_macros      = { workspace = true }
+biome_aria                = { workspace = true }
+biome_aria_metadata       = { workspace = true }
+biome_console             = { workspace = true }
+biome_control_flow        = { workspace = true }
+biome_deserialize         = { workspace = true, features = ["smallvec"] }
+biome_deserialize_macros  = { workspace = true }
+biome_diagnostics         = { workspace = true }
+biome_fs                  = { workspace = true }
+biome_glob                = { workspace = true, features = ["biome_deserialize", "serde"] }
+biome_js_factory          = { workspace = true }
+biome_js_semantic         = { workspace = true }
+biome_js_syntax           = { workspace = true }
+biome_js_type_info        = { workspace = true }
+biome_jsdoc_comment       = { workspace = true }
+biome_module_graph        = { workspace = true }
+biome_module_replacements = { workspace = true }
+biome_package             = { workspace = true }
+biome_project_layout      = { workspace = true }
+biome_resolver            = { workspace = true }
+biome_rowan               = { workspace = true }
+biome_rule_options        = { workspace = true }
+biome_string_case         = { workspace = true, features = ["biome_rowan"] }
+biome_suppression         = { workspace = true }
+biome_tailwind_parser     = { workspace = true }
+biome_tailwind_syntax     = { workspace = true }
+biome_unicode_table       = { workspace = true }
+bitvec                    = "1.0.1"
+camino                    = { workspace = true }
+enumflags2                = { workspace = true }
+globset                   = { workspace = true }
+phf                       = { workspace = true }
+regex                     = { workspace = true }
+roaring                   = "0.11.3"
+rustc-hash                = { workspace = true }
+schemars                  = { workspace = true, optional = true }
+serde                     = { workspace = true, features = ["derive"] }
+smallvec                  = { workspace = true }
 
 [dev-dependencies]
 biome_fs            = { path = "../biome_fs" }

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

@@ -1,4 +1,4 @@
-use crate::services::manifest::Manifest;
+use crate::{services::manifest::Manifest, utils::parse_package_name};
 use biome_analyze::{
     Rule, RuleDiagnostic, RuleDomain, RuleSource, context::RuleContext, declare_lint_rule,
 };
@@ -284,80 +284,9 @@ impl Rule for NoUndeclaredDependencies {
     }
 }
 
-fn parse_package_name(path: &str) -> Option<&str> {
-    let mut in_scope = false;
-    for (i, c) in path.bytes().enumerate() {
-        match c {
-            b'@' if i == 0 => {
-                in_scope = true;
-            }
-            // uppercase characters are not allowed in package name
-            // Here we are more tolerant and accept them.
-            b'A'..=b'Z' | b'a'..=b'z' | b'0'..=b'9' | b'-' | b'_' => {}
-            b'.' if i != 0 => {}
-            b'/' => {
-                if in_scope {
-                    if i == 1 {
-                        // Invalid empty scope
-                        // `@/`
-                        return None;
-                    } else {
-                        // We consumed the scope.
-                        // `@scope/`
-                        in_scope = false;
-                    }
-                } else if i == 0 {
-                    // absolute path
-                    return None;
-                } else {
-                    // We consumed the package name
-                    return Some(&path[..i]);
-                }
-            }
-            _ => {
-                return None;
-            }
-        }
-    }
-    // Handle cases where only the scope is given. e.g. `@scope/`
-    (!path.ends_with('/')).then_some(path)
-}
-
 fn is_type_import(import: &AnyJsImportLike) -> bool {
     match import.parent::<AnyJsImportClause>() {
         Some(clause) => clause.type_token().is_some(),
         _ => false,
     }
 }
-
-#[test]
-fn test() {
-    assert_eq!(
-        parse_package_name("@scope/package-name"),
-        Some("@scope/package-name")
-    );
-    assert_eq!(
-        parse_package_name("@scope/package-name/path"),
-        Some("@scope/package-name")
-    );
-    assert_eq!(parse_package_name("package_"), Some("package_"));
-    assert_eq!(parse_package_name("package/path"), Some("package"));
-    assert_eq!(parse_package_name("0"), Some("0"));
-    assert_eq!(parse_package_name("0/path"), Some("0"));
-    assert_eq!(parse_package_name("-"), Some("-"));
-    assert_eq!(parse_package_name("-/path"), Some("-"));
-    assert_eq!(parse_package_name("a.js"), Some("a.js"));
-    assert_eq!(parse_package_name("@././file"), Some("@./."));
-
-    // Invalid package names that we accept
-    assert_eq!(parse_package_name("PACKAGE"), Some("PACKAGE"));
-    assert_eq!(parse_package_name("_"), Some("_"));
-
-    // Invalid package names that we reject
-    assert_eq!(parse_package_name("@/path"), None);
-    assert_eq!(parse_package_name("."), None);
-    assert_eq!(parse_package_name("./path"), None);
-    assert_eq!(parse_package_name("#path"), None);
-    assert_eq!(parse_package_name("/path"), None);
-    assert_eq!(parse_package_name("p@ckage/name"), None);
-}