fix(js_analyze): handle chained test.each calls in noMisplacedAssertion (#10680)

Author: WaterWhisperer

.changeset/fix-no-misplaced-assertion-concurrent-each.md

@@ -0,0 +1,7 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#10635](https://github.com/biomejs/biome/issues/10635): Biome now recognizes chained
+table tests such as `test.concurrent.each()` and `it.concurrent.each()` as test calls, fixing
+`noMisplacedAssertion` false positives and improving formatting for those test declarations.

crates/biome_js_analyze/tests/specs/suspicious/noMisplacedAssertion/valid.js

@@ -9,6 +9,22 @@ test("something", () => {
 	expect("something").toBeTrue()
 })
 
+test.each(arr)("works as expected", () => {
+	expect();
+});
+
+test.concurrent.each(arr)("works as expected", () => {
+	expect();
+});
+
+it.concurrent.each(arr)("works as expected", () => {
+	expect();
+});
+
+test.concurrent.only.each(arr)("works as expected", () => {
+	expect();
+});
+
 Deno.test("something", () => {
 	expect("something").toBeTrue()
 })
@@ -48,4 +64,4 @@ expect.extend({
 
 expect.addEqualityTesters([areVolumesEqual]);
 
-expect.addSnapshotSerializer(serializer);
+expect.addSnapshotSerializer(serializer);

crates/biome_js_analyze/tests/specs/suspicious/noMisplacedAssertion/valid.js.snap

@@ -15,6 +15,22 @@ test("something", () => {
 	expect("something").toBeTrue()
 })
 
+test.each(arr)("works as expected", () => {
+	expect();
+});
+
+test.concurrent.each(arr)("works as expected", () => {
+	expect();
+});
+
+it.concurrent.each(arr)("works as expected", () => {
+	expect();
+});
+
+test.concurrent.only.each(arr)("works as expected", () => {
+	expect();
+});
+
 Deno.test("something", () => {
 	expect("something").toBeTrue()
 })
@@ -55,4 +71,5 @@ expect.extend({
 expect.addEqualityTesters([areVolumesEqual]);
 
 expect.addSnapshotSerializer(serializer);
+
 ```

crates/biome_js_formatter/tests/specs/js/module/declarations/test_declaration.js

@@ -32,3 +32,9 @@ describe("with retry option", { retry: 2 }, () => {
 it("with timeout option", { timeout: 5000 }, () => {
   console.log("test");
 });
+
+// Chained table test
+test.concurrent.each(arr)(
+  "works as expected", () => {
+  expect();
+});

crates/biome_js_formatter/tests/specs/js/module/declarations/test_declaration.js.snap

@@ -41,6 +41,12 @@ it("with timeout option", { timeout: 5000 }, () => {
   console.log("test");
 });
 
+// Chained table test
+test.concurrent.each(arr)(
+  "works as expected", () => {
+  expect();
+});
+
 ```
 
 
@@ -78,4 +84,9 @@ it("with timeout option", { timeout: 5000 }, () => {
 	console.log("test");
 });
 
+// Chained table test
+test.concurrent.each(arr)("works as expected", () => {
+	expect();
+});
+
 ```

crates/biome_js_syntax/src/expr_ext.rs

@@ -1092,23 +1092,29 @@ impl AnyJsExpression {
         false
     }
 
-    /// Checks whether the current function call is:
-    /// - `it`: many libraries such as Node.js, Mocha, Jest, etc.
-    /// - `test`: many libraries such as Node.js, bun, etc.
+    /// Checks whether the current function call is a test body context:
+    /// - `it` and `test` calls accepted by [`contains_a_test_pattern`], such as
+    ///   `it.only` or `test.concurrent`
+    /// - `it.each` and `test.each` table test calls accepted by
+    ///   [`contains_a_test_each_pattern`], such as `test.concurrent.each`
     /// - [`Deno.test`](https://docs.deno.com/runtime/manual/basics/testing/)
     /// - [`waitFor`](https://testing-library.com/docs/dom-testing-library/api-async/#waitfor)
+    ///
+    /// [`contains_a_test_pattern`]: crate::AnyJsExpression::contains_a_test_pattern
+    /// [`contains_a_test_each_pattern`]: crate::AnyJsExpression::contains_a_test_each_pattern
     pub fn contains_it_call(&self) -> bool {
-        let mut members = CalleeNamesIterator::new(self.clone());
-
-        let texts: [Option<TokenText>; 2] = [members.next(), members.next()];
+        let members = CalleeNamesIterator::new(self.clone()).collect::<Vec<_>>();
 
-        let mut rev = texts.iter().rev().flatten();
+        let mut rev = members.iter().rev();
 
         let first = rev.next().map(|t| t.text());
         let second = rev.next().map(|t| t.text());
 
         match first {
-            Some("test" | "it" | "waitFor") => true,
+            Some("test" | "it") => {
+                self.contains_a_test_pattern() || self.contains_a_test_each_pattern()
+            }
+            Some("waitFor") => true,
             Some("Deno") => matches!(second, Some("test")),
             _ => false,
         }