Skip to content
This repository was archived by the owner on Oct 30, 2023. It is now read-only.

Commit e31ad64

Browse files
authored
Merge pull request #163 from Krasks/master
Fixed market ticker event.
2 parents 8f2bff1 + 15489f0 commit e31ad64

3 files changed

Lines changed: 65 additions & 64 deletions

File tree

src/main/java/com/binance/api/client/domain/event/AllMarketTickersEvent.java

Lines changed: 61 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -20,43 +20,43 @@ public class AllMarketTickersEvent {
2020
private String symbol;
2121

2222
@JsonProperty("p")
23-
private double priceChange;
23+
private String priceChange;
2424

2525
@JsonProperty("P")
26-
private double priceChangePercent;
26+
private String priceChangePercent;
2727

2828
@JsonProperty("w")
29-
private double weightedAveragePrice;
29+
private String weightedAveragePrice;
3030

3131
@JsonProperty("x")
32-
private double previousDaysClosePrice;
32+
private String previousDaysClosePrice;
3333

3434
@JsonProperty("c")
35-
private double currentDaysClosePrice;
35+
private String currentDaysClosePrice;
3636

3737
@JsonProperty("Q")
38-
private long closeTradesQuantity;
38+
private String closeTradesQuantity;
3939

4040
@JsonProperty("a")
41-
private double bestAskPrice;
41+
private String bestAskPrice;
4242

4343
@JsonProperty("A")
44-
private long bestAskQuantity;
44+
private String bestAskQuantity;
4545

4646
@JsonProperty("o")
47-
private double openPrice;
47+
private String openPrice;
4848

4949
@JsonProperty("h")
50-
private double highPrice;
50+
private String highPrice;
5151

5252
@JsonProperty("l")
53-
private double lowPrice;
53+
private String lowPrice;
5454

5555
@JsonProperty("v")
56-
private long totalTradedBaseAssetVolume;
56+
private String totalTradedBaseAssetVolume;
5757

5858
@JsonProperty("q")
59-
private long totalTradedQuoteAssetVolume;
59+
private String totalTradedQuoteAssetVolume;
6060

6161
@JsonProperty("O")
6262
private long statisticesOpenTime;
@@ -97,107 +97,107 @@ public void setSymbol(String symbol) {
9797
this.symbol = symbol;
9898
}
9999

100-
public double getPriceChange() {
100+
public String getPriceChange() {
101101
return priceChange;
102102
}
103103

104-
public void setPriceChange(double priceChange) {
104+
public void setPriceChange(String priceChange) {
105105
this.priceChange = priceChange;
106106
}
107107

108-
public double getPriceChangePercent() {
108+
public String getPriceChangePercent() {
109109
return priceChangePercent;
110110
}
111111

112-
public void setPriceChangePercent(double priceChangePercent) {
112+
public void setPriceChangePercent(String priceChangePercent) {
113113
this.priceChangePercent = priceChangePercent;
114114
}
115115

116-
public double getWeightedAveragePrice() {
116+
public String getWeightedAveragePrice() {
117117
return weightedAveragePrice;
118118
}
119119

120-
public void setWeightedAveragePrice(double weightedAveragePrice) {
120+
public void setWeightedAveragePrice(String weightedAveragePrice) {
121121
this.weightedAveragePrice = weightedAveragePrice;
122122
}
123123

124-
public double getPreviousDaysClosePrice() {
124+
public String getPreviousDaysClosePrice() {
125125
return previousDaysClosePrice;
126126
}
127127

128-
public void setPreviousDaysClosePrice(double previousDaysClosePrice) {
128+
public void setPreviousDaysClosePrice(String previousDaysClosePrice) {
129129
this.previousDaysClosePrice = previousDaysClosePrice;
130130
}
131131

132-
public double getCurrentDaysClosePrice() {
132+
public String getCurrentDaysClosePrice() {
133133
return currentDaysClosePrice;
134134
}
135135

136-
public void setCurrentDaysClosePrice(double currentDaysClosePrice) {
136+
public void setCurrentDaysClosePrice(String currentDaysClosePrice) {
137137
this.currentDaysClosePrice = currentDaysClosePrice;
138138
}
139139

140-
public long getCloseTradesQuantity() {
140+
public String getCloseTradesQuantity() {
141141
return closeTradesQuantity;
142142
}
143143

144-
public void setCloseTradesQuantity(long closeTradesQuantity) {
144+
public void setCloseTradesQuantity(String closeTradesQuantity) {
145145
this.closeTradesQuantity = closeTradesQuantity;
146146
}
147147

148-
public double getBestAskPrice() {
148+
public String getBestAskPrice() {
149149
return bestAskPrice;
150150
}
151151

152-
public void setBestAskPrice(double bestAskPrice) {
152+
public void setBestAskPrice(String bestAskPrice) {
153153
this.bestAskPrice = bestAskPrice;
154154
}
155155

156-
public long getBestAskQuantity() {
156+
public String getBestAskQuantity() {
157157
return bestAskQuantity;
158158
}
159159

160-
public void setBestAskQuantity(long bestAskQuantity) {
160+
public void setBestAskQuantity(String bestAskQuantity) {
161161
this.bestAskQuantity = bestAskQuantity;
162162
}
163163

164-
public double getOpenPrice() {
164+
public String getOpenPrice() {
165165
return openPrice;
166166
}
167167

168-
public void setOpenPrice(double openPrice) {
168+
public void setOpenPrice(String openPrice) {
169169
this.openPrice = openPrice;
170170
}
171171

172-
public double getHighPrice() {
172+
public String getHighPrice() {
173173
return highPrice;
174174
}
175175

176-
public void setHighPrice(double highPrice) {
176+
public void setHighPrice(String highPrice) {
177177
this.highPrice = highPrice;
178178
}
179179

180-
public double getLowPrice() {
180+
public String getLowPrice() {
181181
return lowPrice;
182182
}
183183

184-
public void setLowPrice(double lowPrice) {
184+
public void setLowPrice(String lowPrice) {
185185
this.lowPrice = lowPrice;
186186
}
187187

188-
public long getTotalTradedBaseAssetVolume() {
188+
public String getTotalTradedBaseAssetVolume() {
189189
return totalTradedBaseAssetVolume;
190190
}
191191

192-
public void setTotalTradedBaseAssetVolume(long totalTradedBaseAssetVolume) {
192+
public void setTotalTradedBaseAssetVolume(String totalTradedBaseAssetVolume) {
193193
this.totalTradedBaseAssetVolume = totalTradedBaseAssetVolume;
194194
}
195195

196-
public long getTotalTradedQuoteAssetVolume() {
196+
public String getTotalTradedQuoteAssetVolume() {
197197
return totalTradedQuoteAssetVolume;
198198
}
199199

200-
public void setTotalTradedQuoteAssetVolume(long totalTradedQuoteAssetVolume) {
200+
public void setTotalTradedQuoteAssetVolume(String totalTradedQuoteAssetVolume) {
201201
this.totalTradedQuoteAssetVolume = totalTradedQuoteAssetVolume;
202202
}
203203

@@ -244,27 +244,27 @@ public void setTotalNumberOfTrades(long totalNumberOfTrades) {
244244
@Override
245245
public String toString() {
246246
return new ToStringBuilder(this, BinanceApiConstants.TO_STRING_BUILDER_STYLE)
247-
.append("eventType", eventType)
248-
.append("eventTime", eventTime)
249-
.append("symbol", symbol)
250-
.append("priceChange", priceChange)
251-
.append("priceChangePercent", priceChangePercent)
252-
.append("weightedAveragePrice", weightedAveragePrice)
253-
.append("previousDaysClosePrice", previousDaysClosePrice)
254-
.append("currentDaysClosePrice", currentDaysClosePrice)
255-
.append("closeTradesQuantity", closeTradesQuantity)
256-
.append("bestAskPrice", bestAskPrice)
257-
.append("bestAskQuantity", bestAskQuantity)
258-
.append("openPrice", openPrice)
259-
.append("highPrice", highPrice)
260-
.append("lowPrice", lowPrice)
261-
.append("totalTradedBaseAssetVolume", totalTradedBaseAssetVolume)
262-
.append("totalTradedQuoteAssetVolume", totalTradedQuoteAssetVolume)
263-
.append("statisticesOpenTime", statisticesOpenTime)
264-
.append("statisticesCloseTime", statisticesCloseTime)
265-
.append("firstTradeId", firstTradeId)
266-
.append("lastTradeId", lastTradeId)
267-
.append("totalNumberOfTrades", totalNumberOfTrades)
268-
.toString();
247+
.append("eventType", eventType)
248+
.append("eventTime", eventTime)
249+
.append("symbol", symbol)
250+
.append("priceChange", priceChange)
251+
.append("priceChangePercent", priceChangePercent)
252+
.append("weightedAveragePrice", weightedAveragePrice)
253+
.append("previousDaysClosePrice", previousDaysClosePrice)
254+
.append("currentDaysClosePrice", currentDaysClosePrice)
255+
.append("closeTradesQuantity", closeTradesQuantity)
256+
.append("bestAskPrice", bestAskPrice)
257+
.append("bestAskQuantity", bestAskQuantity)
258+
.append("openPrice", openPrice)
259+
.append("highPrice", highPrice)
260+
.append("lowPrice", lowPrice)
261+
.append("totalTradedBaseAssetVolume", totalTradedBaseAssetVolume)
262+
.append("totalTradedQuoteAssetVolume", totalTradedQuoteAssetVolume)
263+
.append("statisticesOpenTime", statisticesOpenTime)
264+
.append("statisticesCloseTime", statisticesCloseTime)
265+
.append("firstTradeId", firstTradeId)
266+
.append("lastTradeId", lastTradeId)
267+
.append("totalNumberOfTrades", totalNumberOfTrades)
268+
.toString();
269269
}
270270
}

src/main/java/com/binance/api/client/impl/BinanceApiWebSocketClientImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import com.binance.api.client.domain.event.DepthEvent;
1010
import com.binance.api.client.domain.event.UserDataUpdateEvent;
1111
import com.binance.api.client.domain.market.CandlestickInterval;
12+
import com.fasterxml.jackson.core.type.TypeReference;
1213

1314
import okhttp3.OkHttpClient;
1415
import okhttp3.Request;
@@ -50,7 +51,7 @@ public Closeable onUserDataUpdateEvent(String listenKey, BinanceApiCallback<User
5051

5152
public Closeable onAllMarketTickersEvent(BinanceApiCallback<List<AllMarketTickersEvent>> callback) {
5253
final String channel = "!ticker@arr";
53-
return createNewWebSocket(channel, new BinanceApiWebSocketListener<List<AllMarketTickersEvent>>(callback));
54+
return createNewWebSocket(channel, new BinanceApiWebSocketListener<>(callback, new TypeReference<List<AllMarketTickersEvent>>() {}));
5455
}
5556

5657
/**

src/main/java/com/binance/api/client/impl/BinanceApiWebSocketListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ public BinanceApiWebSocketListener(BinanceApiCallback<T> callback, Class<T> even
2727
this.eventClass = eventClass;
2828
}
2929

30-
public BinanceApiWebSocketListener(BinanceApiCallback<T> callback) {
30+
public BinanceApiWebSocketListener(BinanceApiCallback<T> callback, TypeReference<T> eventTypeReference) {
3131
this.callback = callback;
32-
this.eventTypeReference = new TypeReference<T>() {};
32+
this.eventTypeReference = eventTypeReference;
3333
}
3434

3535
@Override

0 commit comments

Comments
 (0)