fix: indent comments

Author: highesttt

pkg/connector/client.go

@@ -80,6 +80,7 @@ type LineClient struct {
 	knownMemberChatMIDs     map[string]struct{} // chatMid -> current member chats returned by getAllChatMids
 	reactionIconMXC         map[int]string      // predefinedReactionType -> cached MXC URI
 	recentReactions         sync.Map            // "msgID\x00emoji" -> struct{} to dedup concurrent 139/140 events
+	unblockBackfills        sync.Map            // chat MID -> *unblockBackfillState while unblock history restoration is active
 
 	wg sync.WaitGroup
 }

pkg/connector/connector.go

@@ -3,6 +3,7 @@ package connector
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"net/http"
 	"strings"
@@ -368,15 +369,20 @@ func parseLoginErrorDetails(err error) loginErrorDetails {
 	return details
 }
 
-func loginErrorSummary(err error) string {
+func loginErrorSummary(err error, details loginErrorDetails) string {
 	if err == nil {
 		return ""
 	}
-	summary := strings.TrimSpace(err.Error())
-	if jsonStart := strings.Index(summary, "{"); jsonStart >= 0 {
-		summary = strings.TrimSpace(summary[:jsonStart])
+	if details.HasHTTPStatus {
+		return fmt.Sprintf("API error %d", details.HTTPStatus)
+	}
+	if errors.Is(err, context.DeadlineExceeded) {
+		return "request timed out"
+	}
+	if errors.Is(err, context.Canceled) {
+		return "request canceled"
 	}
-	return loginLogField(summary)
+	return ""
 }
 
 func loginLogField(value string) string {
@@ -398,7 +404,7 @@ func (ll *LineEmailLogin) logLoginFailure(err error, flow string) {
 	event := ll.User.Log.Warn().
 		Str("login_flow", flow).
 		Bool("has_certificate", ll.Certificate != "")
-	if summary := loginErrorSummary(err); summary != "" {
+	if summary := loginErrorSummary(err, details); summary != "" {
 		event.Str("error_summary", summary)
 	}
 	if details.HasHTTPStatus {

pkg/connector/login_error_logging_test.go

@@ -5,6 +5,7 @@ import (
 	"context"
 	"encoding/json"
 	"errors"
+	"fmt"
 	"strings"
 	"testing"
 
@@ -53,6 +54,7 @@ func TestSubmitUserInputLogsStructuredLoginErrorWithoutCredentials(t *testing.T)
 		"message":               "LINE login attempt failed",
 		"login_flow":            "credentials",
 		"has_certificate":       false,
+		"error_summary":         "API error 400",
 		"http_status":           float64(400),
 		"line_response_code":    float64(10051),
 		"line_response_message": "RESPONSE_ERROR",
@@ -76,11 +78,28 @@ func TestSubmitUserInputLogsStructuredLoginErrorWithoutCredentials(t *testing.T)
 }
 
 func TestParseLoginErrorDetailsWithoutJSON(t *testing.T) {
-	details := parseLoginErrorDetails(errors.New("login failed: request failed: context deadline exceeded"))
+	err := errors.New("login failed: request failed: context deadline exceeded")
+	details := parseLoginErrorDetails(err)
 	if details.HasHTTPStatus || details.HasResponseFields {
 		t.Fatalf("unexpected parsed response details: %#v", details)
 	}
-	if got := loginErrorSummary(errors.New("login failed: request failed: context deadline exceeded")); got != "login failed: request failed: context deadline exceeded" {
-		t.Fatalf("loginErrorSummary = %q", got)
+	if got := loginErrorSummary(err, details); got != "" {
+		t.Fatalf("loginErrorSummary = %q, want empty", got)
+	}
+}
+
+func TestLoginErrorSummaryDoesNotIncludeNonJSONResponseBody(t *testing.T) {
+	err := errors.New("login failed: API error 502: upstream secret response")
+	details := parseLoginErrorDetails(err)
+	if got := loginErrorSummary(err, details); got != "API error 502" {
+		t.Fatalf("loginErrorSummary = %q, want %q", got, "API error 502")
+	}
+}
+
+func TestLoginErrorSummaryAllowsKnownContextErrors(t *testing.T) {
+	err := fmt.Errorf("login failed: %w", context.DeadlineExceeded)
+	details := parseLoginErrorDetails(err)
+	if got := loginErrorSummary(err, details); got != "request timed out" {
+		t.Fatalf("loginErrorSummary = %q, want %q", got, "request timed out")
 	}
 }