Skip to content

a must sometimes be able to be a # - #93

Merged
bcoe merged 2 commits into
masterfrom
windows-hot-fix
Dec 14, 2015
Merged

a must sometimes be able to be a ##93
bcoe merged 2 commits into
masterfrom
windows-hot-fix

Conversation

@bcoe

@bcoe bcoe commented Dec 14, 2015

Copy link
Copy Markdown
Member

No description provided.

@novemberborn

Copy link
Copy Markdown
Contributor

I think your commit messages means "a must sometimes be a number"? Maybe? Could test for a string type instead of the replace method I suppose.

@bcoe bcoe changed the title a must sometimes be able to be a # a must sometimes be able to be a # Dec 14, 2015
@bcoe

bcoe commented Dec 14, 2015

Copy link
Copy Markdown
Member Author

@novemberborn I like that approach better, covers our butt if argv ever has null or undefined in it -- I don't think this is possible, but better safe than sorry.

bcoe added a commit that referenced this pull request Dec 14, 2015
`a` must sometimes be able to be a #
@bcoe
bcoe merged commit b36d87c into master Dec 14, 2015
@bcoe
bcoe deleted the windows-hot-fix branch December 14, 2015 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants