Skip to content

feat: upgrade to new test-exclude; with suppport for node_modules - #348

Merged
bcoe merged 1 commit into
masterfrom
test-exclude-upgrade
Aug 12, 2016
Merged

feat: upgrade to new test-exclude; with suppport for node_modules#348
bcoe merged 1 commit into
masterfrom
test-exclude-upgrade

Conversation

@bcoe

@bcoe bcoe commented Aug 12, 2016

Copy link
Copy Markdown
Member

BREAKING CHANGE: node_modules is no longer automatically excluded, and an empty array of exclude rules can be provided.

@bcoe
bcoe merged commit d616ffc into master Aug 12, 2016
@bcoe
bcoe deleted the test-exclude-upgrade branch August 12, 2016 05:55
@sindresorhus

Copy link
Copy Markdown
Member

node_modules is no longer automatically excluded

Why? This is very inconvenient and different from most other tools (AVA, ESLint, etc).

@bcoe

bcoe commented Oct 3, 2016

Copy link
Copy Markdown
Member Author

@sindresorhus node_modules is still excluded by the default set of rules, but if you opt to provide your own exclude rules, you must provide it yourself.

Several folks were asking to be able to instrument files in their node_modules folder, which was impossible with the old API, so I thought this was an okay compromise.

@sindresorhus

Copy link
Copy Markdown
Member

@bcoe That's what negated globs are for: ["!node_modules"] should have re-enabled node_modules.

@bcoe

bcoe commented Oct 3, 2016

Copy link
Copy Markdown
Member Author

@sindresorhus that's smart, I would definitely be comfortable with moving towards this.

@sindresorhus

Copy link
Copy Markdown
Member

Where should I open an issue? Here or test-exclude?

@bcoe

bcoe commented Oct 3, 2016

Copy link
Copy Markdown
Member Author

@sindresorhus 👍 yeah, seems reasonable; this would be another breaking change; but worthwhile you think? covering node_modules is an edge-case, and we can help those people one by one.

@sindresorhus

Copy link
Copy Markdown
Member

Yeah, I think it's worth it. Very few would cover node_modules, but many would define some excludes, which means they would need to needlessly include node_modules.

@bcoe

bcoe commented Oct 3, 2016

Copy link
Copy Markdown
Member Author

@sindresorhus sorry, only half answered your question; let's open an issue on test-exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants