feat: nyc no longer tries to run arguments passed to the instrumented bin - #322
Merged
Conversation
| var args = JSON.parse(stdout) | ||
| args.should.include('--help') | ||
| args.should.include('--version') | ||
| args.should.not.include('--silent') |
|
Nice work! Thank you for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is an attempt to make nyc's argument parsing more clever, in the past:
nyc npm test --silentwould have resulted in
nycitself reading the--silentflag, and failing to print output.With this fix, nyc instead parses:
nyc npm test, dropping the trailing arguments.fixes: #99, #201
Reviewers: @MoOx, @jamestalmage, @danez, @JaKXz