Skip to content

Latest commit

 

History

History
21 lines (14 loc) · 950 Bytes

File metadata and controls

21 lines (14 loc) · 950 Bytes

Definition of Done

After completing your implementation, review your own changes against each criterion below. These are quality checks you perform by inspecting your work — not commands to run (linting and tests already ran via validationCommand). Report any unmet criterion as a blocker.

Code Quality

  • Exported types, functions, and interfaces have doc comments
  • Error handling uses github.com/bborbe/errors with context wrapping
  • No debug output (print statements, fmt.Printf) — use structured logging
  • Factory functions are pure composition — no conditionals, no I/O, no context.Background()
  • Follow Interface → Constructor → Struct → Method pattern

Testing

  • New code has good test coverage (target >= 80%)
  • Changes to existing code have tests covering at least the changed behavior
  • Tests use Ginkgo v2 / Gomega with Counterfeiter mocks

Documentation

  • CHANGELOG.md has an entry under ## Unreleased