Skip to content

Commit a4a3b18

Browse files
author
Justin Skiles
authored
Merge pull request #37 from babelshift/cleanup-and-better-numerical-types
Cleanup and better numerical types
2 parents 8ac5896 + 5561963 commit a4a3b18

96 files changed

Lines changed: 666 additions & 546 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,6 @@ var playerSummary = await steamInterface.GetPlayerSummaryAsync(<steamIdHere>);
5151
// see FriendListResultContainer.cs for response documentation
5252
var friendsList = await steamInterface.GetFriendsListAsync(<steamIdHere>);
5353
```
54+
55+
## Changes from 2.0 to 3.0
56+
In versions previous to 3.0, numerical types were treated as short, int, and long. This caused problems when interacting with the Steam Web API because Valve accepts and returns unsigned numerical types. Instead of constantly reacting to overflows when a specific endpoint would return something outside the bounds of a 32-bit int, I decided to switch all numerical types to their unsigned counterparts.

‎SteamWebAPI2.Net451/Properties/AssemblyInfo.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@
3232
// You can specify all the values or you can default the Build and Revision Numbers
3333
// by using the '*' as shown below:
3434
// [assembly: AssemblyVersion("1.0.*")]
35-
[assembly: AssemblyVersion("2.0.0.0")]
36-
[assembly: AssemblyFileVersion("2.0.0.0")]
35+
[assembly: AssemblyVersion("3.0.0.0")]
36+
[assembly: AssemblyFileVersion("3.0.0.0")]

‎SteamWebAPI2.Net451/SteamWebAPI2.Net451.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
<HintPath>..\packages\Newtonsoft.Json.9.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
4040
<Private>True</Private>
4141
</Reference>
42-
<Reference Include="Steam.Models, Version=1.0.0.53, Culture=neutral, processorArchitecture=MSIL">
43-
<HintPath>..\packages\Steam.Models.1.0.0.53\lib\net451\Steam.Models.dll</HintPath>
42+
<Reference Include="Steam.Models, Version=2.0.0.1, Culture=neutral, processorArchitecture=MSIL">
43+
<HintPath>..\packages\Steam.Models.2.0.0.1\lib\net451\Steam.Models.dll</HintPath>
4444
<Private>True</Private>
4545
</Reference>
4646
<Reference Include="System" />

‎SteamWebAPI2.Net451/packages.config‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
<packages>
33
<package id="AutoMapper" version="4.2.1" targetFramework="net451" />
44
<package id="Newtonsoft.Json" version="9.0.1" targetFramework="net451" />
5-
<package id="Steam.Models" version="1.0.0.53" targetFramework="net451" />
5+
<package id="Steam.Models" version="2.0.0.1" targetFramework="net451" />
66
</packages>

‎SteamWebAPI2.Net452/Properties/AssemblyInfo.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@
3232
// You can specify all the values or you can default the Build and Revision Numbers
3333
// by using the '*' as shown below:
3434
// [assembly: AssemblyVersion("1.0.*")]
35-
[assembly: AssemblyVersion("2.0.0.0")]
36-
[assembly: AssemblyFileVersion("2.0.0.0")]
35+
[assembly: AssemblyVersion("3.0.0.0")]
36+
[assembly: AssemblyFileVersion("3.0.0.0")]

‎SteamWebAPI2.Net452/SteamWebAPI2.Net452.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
<HintPath>..\packages\Newtonsoft.Json.9.0.1\lib\net45\Newtonsoft.Json.dll</HintPath>
4040
<Private>True</Private>
4141
</Reference>
42-
<Reference Include="Steam.Models, Version=1.0.0.53, Culture=neutral, processorArchitecture=MSIL">
43-
<HintPath>..\packages\Steam.Models.1.0.0.53\lib\net452\Steam.Models.dll</HintPath>
42+
<Reference Include="Steam.Models, Version=2.0.0.1, Culture=neutral, processorArchitecture=MSIL">
43+
<HintPath>..\packages\Steam.Models.2.0.0.1\lib\net452\Steam.Models.dll</HintPath>
4444
<Private>True</Private>
4545
</Reference>
4646
<Reference Include="System" />

‎SteamWebAPI2.Net452/packages.config‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
<packages>
33
<package id="AutoMapper" version="4.2.1" targetFramework="net452" />
44
<package id="Newtonsoft.Json" version="9.0.1" targetFramework="net452" />
5-
<package id="Steam.Models" version="1.0.0.53" targetFramework="net452" />
5+
<package id="Steam.Models" version="2.0.0.1" targetFramework="net452" />
66
</packages>

‎SteamWebAPI2.Tests/Properties/AssemblyInfo.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@
3232
// You can specify all the values or you can default the Build and Revision Numbers
3333
// by using the '*' as shown below:
3434
// [assembly: AssemblyVersion("1.0.*")]
35-
[assembly: AssemblyVersion("1.0.0.0")]
36-
[assembly: AssemblyFileVersion("1.0.0.0")]
35+
[assembly: AssemblyVersion("3.0.0.0")]
36+
[assembly: AssemblyFileVersion("3.0.0.0")]

‎SteamWebAPI2.Tests/SteamWebAPI2.Tests.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
<HintPath>..\packages\Moq.4.5.30\lib\net45\Moq.dll</HintPath>
4545
<Private>True</Private>
4646
</Reference>
47-
<Reference Include="Steam.Models, Version=1.0.0.53, Culture=neutral, processorArchitecture=MSIL">
48-
<HintPath>..\packages\Steam.Models.1.0.0.53\lib\net46\Steam.Models.dll</HintPath>
47+
<Reference Include="Steam.Models, Version=2.0.0.1, Culture=neutral, processorArchitecture=MSIL">
48+
<HintPath>..\packages\Steam.Models.2.0.0.1\lib\net46\Steam.Models.dll</HintPath>
4949
<Private>True</Private>
5050
</Reference>
5151
<Reference Include="System" />

‎SteamWebAPI2.Tests/packages.config‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
<packages>
33
<package id="Castle.Core" version="3.3.3" targetFramework="net461" />
44
<package id="Moq" version="4.5.30" targetFramework="net461" />
5-
<package id="Steam.Models" version="1.0.0.53" targetFramework="net461" />
5+
<package id="Steam.Models" version="2.0.0.1" targetFramework="net461" />
66
</packages>

0 commit comments

Comments
 (0)