Skip to content

Commit 9773e0e

Browse files
author
Justin
committed
Fixed bug where some PlayerService methods would return errors because parameters were ignored.
Removed double parameters added to method to GetOwnedGames.
1 parent 31ea6dd commit 9773e0e

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

SteamWebAPI2/Interfaces/PlayerService.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,36 +19,36 @@ public PlayerService(string steamWebApiKey)
1919
public async Task<string> IsPlayingSharedGameAsync(long steamId, int appId)
2020
{
2121
List<SteamWebRequestParameter> parameters = new List<SteamWebRequestParameter>();
22-
var playingSharedGameResult = await CallMethodAsync<PlayingSharedGameResultContainer>("IsPlayingSharedGame", 1, parameters);
2322
parameters.AddIfHasValue(steamId, "steamid");
2423
parameters.AddIfHasValue(appId, "appid_playing");
24+
var playingSharedGameResult = await CallMethodAsync<PlayingSharedGameResultContainer>("IsPlayingSharedGame", 1, parameters);
2525
return playingSharedGameResult.Result.LenderSteamId;
2626
}
2727

2828
public async Task<IReadOnlyCollection<BadgeQuestModel>> GetCommunityBadgeProgressAsync(long steamId, int? badgeId = null)
2929
{
3030
List<SteamWebRequestParameter> parameters = new List<SteamWebRequestParameter>();
31-
var badgeProgressResult = await CallMethodAsync<CommunityBadgeProgressResultContainer>("GetCommunityBadgeProgress", 1, parameters);
3231
parameters.AddIfHasValue(steamId, "steamid");
3332
parameters.AddIfHasValue(badgeId, "badgeid");
33+
var badgeProgressResult = await CallMethodAsync<CommunityBadgeProgressResultContainer>("GetCommunityBadgeProgress", 1, parameters);
3434
var badgeProgressModels = AutoMapperConfiguration.Mapper.Map<IList<BadgeQuest>, IList<BadgeQuestModel>>(badgeProgressResult.Result.Quests);
3535
return new ReadOnlyCollection<BadgeQuestModel>(badgeProgressModels);
3636
}
3737

3838
public async Task<BadgesResultModel> GetBadgesAsync(long steamId)
3939
{
4040
List<SteamWebRequestParameter> parameters = new List<SteamWebRequestParameter>();
41-
var badgesResult = await CallMethodAsync<BadgesResultContainer>("GetBadges", 1, parameters);
4241
parameters.AddIfHasValue(steamId, "steamid");
42+
var badgesResult = await CallMethodAsync<BadgesResultContainer>("GetBadges", 1, parameters);
4343
var badgesResultModel = AutoMapperConfiguration.Mapper.Map<BadgesResult, BadgesResultModel>(badgesResult.Result);
4444
return badgesResultModel;
4545
}
4646

4747
public async Task<int> GetSteamLevelAsync(long steamId)
4848
{
4949
List<SteamWebRequestParameter> parameters = new List<SteamWebRequestParameter>();
50-
var steamLevelResult = await CallMethodAsync<SteamLevelResultContainer>("GetSteamLevel", 1, parameters);
5150
parameters.AddIfHasValue(steamId, "steamid");
51+
var steamLevelResult = await CallMethodAsync<SteamLevelResultContainer>("GetSteamLevel", 1, parameters);
5252
return steamLevelResult.Result.PlayerLevel;
5353
}
5454

@@ -64,7 +64,6 @@ public async Task<OwnedGamesResultModel> GetOwnedGamesAsync(long steamId, bool?
6464
parameters.AddIfHasValue(includeFreeGamesBit, "include_played_Free_games");
6565
parameters.AddIfHasValue(steamId, "steamid");
6666
parameters.AddIfHasValue(includeAppInfoBit, "include_appinfo");
67-
parameters.AddIfHasValue(includeFreeGamesBit, "include_played_Free_games");
6867

6968
if (appIdsToFilter != null)
7069
{
@@ -94,8 +93,8 @@ public async Task<OwnedGamesResultModel> GetOwnedGamesAsync(long steamId, bool?
9493
public async Task<RecentlyPlayedGamesResultModel> GetRecentlyPlayedGamesAsync(long steamId)
9594
{
9695
List<SteamWebRequestParameter> parameters = new List<SteamWebRequestParameter>();
97-
var recentlyPlayedGamesResult = await CallMethodAsync<RecentlyPlayedGameResultContainer>("GetRecentlyPlayedGames", 1, parameters);
9896
parameters.AddIfHasValue(steamId, "steamid");
97+
var recentlyPlayedGamesResult = await CallMethodAsync<RecentlyPlayedGameResultContainer>("GetRecentlyPlayedGames", 1, parameters);
9998

10099
var recentlyPlayedGamesResultModel = AutoMapperConfiguration.Mapper.Map<RecentlyPlayedGameResult, RecentlyPlayedGamesResultModel>(recentlyPlayedGamesResult.Result);
101100

0 commit comments

Comments
 (0)