Fixing some unsigned typed issues.

Justin · Justin · commit 3ec39f6b2b51 · 2018-01-26T22:35:37.000-05:00
diff --git a/src/SteamWebAPI2/AutoMapperConfiguration.cs b/src/SteamWebAPI2/AutoMapperConfiguration.cs
@@ -382,7 +382,11 @@ public static void Initialize()
 
                     #region Endpoint: SteamRemoteStorage
 
-                    x.CreateMap<uint, PublishedFileVisibility>();
+                    x.CreateMap<uint, PublishedFileVisibility>()
+                        .ConvertUsing(src =>
+                        {
+                            return (PublishedFileVisibility)src;
+                        });
                     x.CreateMap<PublishedFileDetails, PublishedFileDetailsModel>()
                         .ForMember(dest => dest.FileUrl, opts => opts.MapFrom(source => new Uri(source.FileUrl)))
                         .ForMember(dest => dest.PreviewUrl, opts => opts.MapFrom(source => new Uri(source.PreviewUrl)));
diff --git a/src/SteamWebAPI2/Interfaces/SteamNews.cs b/src/SteamWebAPI2/Interfaces/SteamNews.cs
@@ -32,7 +32,7 @@ public SteamNews(string steamWebApiKey, ISteamWebInterface steamWebInterface = n
         /// <returns></returns>
         public async Task<ISteamWebResponse<SteamNewsResultModel>> GetNewsForAppAsync(uint appId, uint? maxLength = null, DateTime? endDate = null, uint? count = null)
         {
-            long? endDateUnixTimeStamp = null;
+            ulong? endDateUnixTimeStamp = null;
 
             if (endDate.HasValue)
             {
diff --git a/src/SteamWebAPI2/Interfaces/SteamUserStats.cs b/src/SteamWebAPI2/Interfaces/SteamUserStats.cs
@@ -56,8 +56,8 @@ public async Task<ISteamWebResponse<IReadOnlyCollection<GlobalAchievementPercent
         /// <returns></returns>
         public async Task<ISteamWebResponse<IReadOnlyCollection<GlobalStatModel>>> GetGlobalStatsForGameAsync(uint appId, IReadOnlyList<string> statNames, DateTime? startDate = null, DateTime? endDate = null)
         {
-            long? startDateUnixTimeStamp = null;
-            long? endDateUnixTimeStamp = null;
+            ulong? startDateUnixTimeStamp = null;
+            ulong? endDateUnixTimeStamp = null;
 
             if (startDate.HasValue)
             {
diff --git a/src/SteamWebAPI2/Models/CSGO/ServerStatusResultContainer.cs b/src/SteamWebAPI2/Models/CSGO/ServerStatusResultContainer.cs
@@ -6,8 +6,8 @@ namespace SteamWebAPI2.Models.CSGO
 {
     internal class ServerStatusApp
     {
-        public int Version { get; set; }
-        public long Timestamp { get; set; }
+        public uint Version { get; set; }
+        public ulong Timestamp { get; set; }
         public string Time { get; set; }
     }
 
@@ -23,16 +23,16 @@ internal class ServerStatusMatchmaking
         public string Scheduler { get; set; }
 
         [JsonProperty(PropertyName = "online_servers")]
-        public int OnlineServers { get; set; }
+        public uint OnlineServers { get; set; }
 
         [JsonProperty(PropertyName = "online_players")]
-        public int OnlinePlayers { get; set; }
+        public uint OnlinePlayers { get; set; }
 
         [JsonProperty(PropertyName = "searching_players")]
-        public int SearchingPlayers { get; set; }
+        public uint SearchingPlayers { get; set; }
 
         [JsonProperty(PropertyName = "search_seconds_avg")]
-        public int SearchSecondsAverage { get; set; }
+        public uint SearchSecondsAverage { get; set; }
     }
 
     internal class ServerStatusServices
diff --git a/src/SteamWebAPI2/Models/DOTA2/MatchDetailResultContainer.cs b/src/SteamWebAPI2/Models/DOTA2/MatchDetailResultContainer.cs
@@ -99,7 +99,7 @@ internal class MatchDetailResult
         public uint Duration { get; set; }
 
         [JsonProperty(PropertyName = "start_time")]
-        public long StartTime { get; set; }
+        public ulong StartTime { get; set; }
 
         [JsonProperty(PropertyName = "match_id")]
         public ulong MatchId { get; set; }
diff --git a/src/SteamWebAPI2/Models/DOTA2/TeamInfoResultContainer.cs b/src/SteamWebAPI2/Models/DOTA2/TeamInfoResultContainer.cs
@@ -9,7 +9,7 @@ internal class TeamInfo
         public uint TeamId { get; set; }
         public string Name { get; set; }
         public string Tag { get; set; }
-        public long TimeCreated { get; set; }
+        public ulong TimeCreated { get; set; }
         public string Rating { get; set; }
         public ulong Logo { get; set; }
         public ulong LogoSponsor { get; set; }
diff --git a/src/SteamWebAPI2/Models/SchemaForGameResultContainer.cs b/src/SteamWebAPI2/Models/SchemaForGameResultContainer.cs
@@ -9,7 +9,7 @@ internal class SchemaGameStat
         public string Name { get; set; }
 
         [JsonProperty("defaultvalue")]
-        public int DefaultValue { get; set; }
+        public uint DefaultValue { get; set; }
 
         [JsonProperty("displayName")]
         public string DisplayName { get; set; }
@@ -21,13 +21,13 @@ internal class SchemaGameAchievement
         public string Name { get; set; }
 
         [JsonProperty("defaultvalue")]
-        public int DefaultValue { get; set; }
+        public uint DefaultValue { get; set; }
 
         [JsonProperty("displayName")]
         public string DisplayName { get; set; }
 
         [JsonProperty("hidden")]
-        public int Hidden { get; set; }
+        public uint Hidden { get; set; }
 
         [JsonProperty("description")]
         public string Description { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamAppListResultContainer.cs b/src/SteamWebAPI2/Models/SteamAppListResultContainer.cs
@@ -6,7 +6,7 @@ namespace SteamWebAPI2.Models
     internal class SteamApp
     {
         [JsonProperty("appid")]
-        public int AppId { get; set; }
+        public uint AppId { get; set; }
 
         [JsonProperty("name")]
         public string Name { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamAppUpToDateCheckResultContainer.cs b/src/SteamWebAPI2/Models/SteamAppUpToDateCheckResultContainer.cs
@@ -14,7 +14,7 @@ internal class SteamAppUpToDateCheckResult
         public bool VersionIsListable { get; set; }
 
         [JsonProperty("required_version")]
-        public int RequiredVersion { get; set; }
+        public uint RequiredVersion { get; set; }
 
         [JsonProperty("message")]
         public string Message { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamCommunity/GlobalStatsForGameResultContainer.cs b/src/SteamWebAPI2/Models/SteamCommunity/GlobalStatsForGameResultContainer.cs
@@ -17,7 +17,7 @@ internal class GlobalStatsForGameResult
         public IList<GlobalStat> GlobalStats { get; set; }
 
         [JsonProperty("result")]
-        public int Status { get; set; }
+        public uint Status { get; set; }
     }
 
     internal class GlobalStatsForGameResultContainer
diff --git a/src/SteamWebAPI2/Models/SteamEconomy/TradeHistoryResultContainer.cs b/src/SteamWebAPI2/Models/SteamEconomy/TradeHistoryResultContainer.cs
@@ -140,10 +140,10 @@ internal class Trade
         public ulong TradeParterSteamId { get; set; }
 
         [JsonProperty("time_init")]
-        public long TimeTradeStarted { get; set; }
+        public ulong TimeTradeStarted { get; set; }
 
         [JsonProperty("time_escrow_end")]
-        public long TimeEscrowEnds { get; set; }
+        public ulong TimeEscrowEnds { get; set; }
 
         [JsonProperty("status")]
         public TradeStatus TradeStatus { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamEconomy/TradeOffer.cs b/src/SteamWebAPI2/Models/SteamEconomy/TradeOffer.cs
@@ -15,7 +15,7 @@ internal class TradeOffer
         public string Message { get; set; }
 
         [JsonProperty("expiration_time")]
-        public long TimeExpiration { get; set; }
+        public ulong TimeExpiration { get; set; }
 
         [JsonProperty("trade_offer_state")]
         public TradeOfferState TradeOfferState { get; set; }
@@ -30,16 +30,16 @@ internal class TradeOffer
         public bool IsOfferYouCreated { get; set; }
 
         [JsonProperty("time_created")]
-        public long TimeCreated { get; set; }
+        public ulong TimeCreated { get; set; }
 
         [JsonProperty("time_updated")]
-        public long TimeUpdated { get; set; }
+        public ulong TimeUpdated { get; set; }
 
         [JsonProperty("from_real_time_trade")]
         public bool WasCreatedFromRealTimeTrade { get; set; }
 
         [JsonProperty("escrow_end_date")]
-        public long TimeEscrowEnds { get; set; }
+        public ulong TimeEscrowEnds { get; set; }
 
         [JsonProperty("confirmation_method")]
         public TradeOfferConfirmationMethod ConfirmationMethod { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamInterface.cs b/src/SteamWebAPI2/Models/SteamInterface.cs
@@ -17,7 +17,7 @@ public SteamInterface()
     internal class SteamMethod
     {
         public string Name { get; set; }
-        public int Version { get; set; }
+        public uint Version { get; set; }
         public string HttpMethod { get; set; }
         public string Description { get; set; }
         public IList<SteamParameter> Parameters { get; private set; }
diff --git a/src/SteamWebAPI2/Models/SteamNewsResultContainer.cs b/src/SteamWebAPI2/Models/SteamNewsResultContainer.cs
@@ -27,7 +27,7 @@ internal class NewsItem
         public string FeedLabel { get; set; }
 
         [JsonProperty("date")]
-        public int Date { get; set; }
+        public uint Date { get; set; }
 
         [JsonProperty("feedname")]
         public string Feedname { get; set; }
@@ -36,7 +36,7 @@ internal class NewsItem
     internal class SteamNewsResult
     {
         [JsonProperty("appid")]
-        public int AppId { get; set; }
+        public uint AppId { get; set; }
 
         [JsonProperty("newsitems")]
         public IList<NewsItem> NewsItems { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamPlayer/CurrentPlayersResultContainer.cs b/src/SteamWebAPI2/Models/SteamPlayer/CurrentPlayersResultContainer.cs
@@ -8,7 +8,7 @@ internal class CurrentPlayersResult
         public uint PlayerCount { get; set; }
 
         [JsonProperty("result")]
-        public int Result { get; set; }
+        public uint Result { get; set; }
     }
 
     internal class CurrentPlayersResultContainer
diff --git a/src/SteamWebAPI2/Models/SteamStore/AppDetailsContainer.cs b/src/SteamWebAPI2/Models/SteamStore/AppDetailsContainer.cs
@@ -66,7 +66,7 @@ internal class PackageGroup
         public string SaveText { get; set; }
 
         [JsonProperty("display_type")]
-        public int DisplayType { get; set; }
+        public uint DisplayType { get; set; }
 
         [JsonProperty("is_recurring_subscription")]
         public string IsRecurringSubscription { get; set; }
diff --git a/src/SteamWebAPI2/Models/SteamStore/FeaturedCategoriesContainer.cs b/src/SteamWebAPI2/Models/SteamStore/FeaturedCategoriesContainer.cs
@@ -47,7 +47,7 @@ internal class Item
         public bool StreamingvideoAvailable { get; set; }
 
         [JsonProperty("discount_expiration")]
-        public int DiscountExpiration { get; set; }
+        public uint DiscountExpiration { get; set; }
 
         [JsonProperty("header_image")]
         public string HeaderImage { get; set; }
@@ -146,6 +146,6 @@ internal class FeaturedCategoriesContainer
         public TrailerSlideshow TrailerSlideshow { get; set; }
 
         [JsonProperty("status")]
-        public int Status { get; set; }
+        public uint Status { get; set; }
     }
 }
diff --git a/src/SteamWebAPI2/Models/SteamStore/FeaturedProductsContainer.cs b/src/SteamWebAPI2/Models/SteamStore/FeaturedProductsContainer.cs
@@ -5,10 +5,10 @@ namespace SteamWebAPI2.Models.SteamStore
     internal class LargeCapsule
     {
         [JsonProperty("id")]
-        public int Id { get; set; }
+        public uint Id { get; set; }
 
         [JsonProperty("type")]
-        public int Type { get; set; }
+        public uint Type { get; set; }
 
         [JsonProperty("name")]
         public string Name { get; set; }
@@ -17,13 +17,13 @@ internal class LargeCapsule
         public bool Discounted { get; set; }
 
         [JsonProperty("discount_percent")]
-        public int DiscountPercent { get; set; }
+        public uint DiscountPercent { get; set; }
 
         [JsonProperty("original_price")]
-        public int? OriginalPrice { get; set; }
+        public uint? OriginalPrice { get; set; }
 
         [JsonProperty("final_price")]
-        public int FinalPrice { get; set; }
+        public uint FinalPrice { get; set; }
 
         [JsonProperty("currency")]
         public string Currency { get; set; }
@@ -59,10 +59,10 @@ internal class LargeCapsule
     internal class FeaturedWin
     {
         [JsonProperty("id")]
-        public int Id { get; set; }
+        public uint Id { get; set; }
 
         [JsonProperty("type")]
-        public int Type { get; set; }
+        public uint Type { get; set; }
 
         [JsonProperty("name")]
         public string Name { get; set; }
@@ -71,13 +71,13 @@ internal class FeaturedWin
         public bool Discounted { get; set; }
 
         [JsonProperty("discount_percent")]
-        public int DiscountPercent { get; set; }
+        public uint DiscountPercent { get; set; }
 
         [JsonProperty("original_price")]
-        public int? OriginalPrice { get; set; }
+        public uint? OriginalPrice { get; set; }
 
         [JsonProperty("final_price")]
-        public int FinalPrice { get; set; }
+        public uint FinalPrice { get; set; }
 
         [JsonProperty("currency")]
         public string Currency { get; set; }
@@ -113,10 +113,10 @@ internal class FeaturedWin
     internal class FeaturedMac
     {
         [JsonProperty("id")]
-        public int Id { get; set; }
+        public uint Id { get; set; }
 
         [JsonProperty("type")]
-        public int Type { get; set; }
+        public uint Type { get; set; }
 
         [JsonProperty("name")]
         public string Name { get; set; }
@@ -125,13 +125,13 @@ internal class FeaturedMac
         public bool Discounted { get; set; }
 
         [JsonProperty("discount_percent")]
-        public int DiscountPercent { get; set; }
+        public uint DiscountPercent { get; set; }
 
         [JsonProperty("original_price")]
-        public int? OriginalPrice { get; set; }
+        public uint? OriginalPrice { get; set; }
 
         [JsonProperty("final_price")]
-        public int FinalPrice { get; set; }
+        public uint FinalPrice { get; set; }
 
         [JsonProperty("currency")]
         public string Currency { get; set; }
@@ -164,10 +164,10 @@ internal class FeaturedMac
     internal class FeaturedLinux
     {
         [JsonProperty("id")]
-        public int Id { get; set; }
+        public uint Id { get; set; }
 
         [JsonProperty("type")]
-        public int Type { get; set; }
+        public uint Type { get; set; }
 
         [JsonProperty("name")]
         public string Name { get; set; }
@@ -176,13 +176,13 @@ internal class FeaturedLinux
         public bool Discounted { get; set; }
 
         [JsonProperty("discount_percent")]
-        public int DiscountPercent { get; set; }
+        public uint DiscountPercent { get; set; }
 
         [JsonProperty("original_price")]
-        public int? OriginalPrice { get; set; }
+        public uint? OriginalPrice { get; set; }
 
         [JsonProperty("final_price")]
-        public int FinalPrice { get; set; }
+        public uint FinalPrice { get; set; }
 
         [JsonProperty("currency")]
         public string Currency { get; set; }
@@ -230,6 +230,6 @@ internal class FeaturedProductsContainer
         public string Layout { get; set; }
 
         [JsonProperty("status")]
-        public int Status { get; set; }
+        public uint Status { get; set; }
     }
 }
diff --git a/src/SteamWebAPI2/Models/TF2/GoldenWrenchResultContainer.cs b/src/SteamWebAPI2/Models/TF2/GoldenWrenchResultContainer.cs
@@ -15,10 +15,10 @@ internal class GoldenWrench
         public DateTime Timestamp { get; set; }
 
         [JsonProperty("itemID")]
-        public int ItemId { get; set; }
+        public uint ItemId { get; set; }
 
         [JsonProperty("wrenchNumber")]
-        public int WrenchNumber { get; set; }
+        public uint WrenchNumber { get; set; }
     }
 
     internal class GoldenWrenchResult
diff --git a/src/SteamWebAPI2/Models/UGCFileDetailsResultContainer.cs b/src/SteamWebAPI2/Models/UGCFileDetailsResultContainer.cs
@@ -12,6 +12,6 @@ internal class UGCFileDetails
     {
         public string FileName { get; set; }
         public string URL { get; set; }
-        public int Size { get; set; }
+        public uint Size { get; set; }
     }
 }
diff --git a/src/SteamWebAPI2/Models/UserStatsForGameResultContainer.cs b/src/SteamWebAPI2/Models/UserStatsForGameResultContainer.cs
@@ -18,7 +18,7 @@ internal class UserStatAchievement
         public string Name { get; set; }
 
         [JsonProperty("achieved")]
-        public int Achieved { get; set; }
+        public uint Achieved { get; set; }
     }
 
     internal class UserStatsForGameResult
diff --git a/src/SteamWebAPI2/SteamWebAPI2.csproj b/src/SteamWebAPI2/SteamWebAPI2.csproj
diff --git a/src/SteamWebAPI2/Utilities/DateTimeExtensions.cs b/src/SteamWebAPI2/Utilities/DateTimeExtensions.cs
diff --git a/src/SteamWebAPI2/Utilities/JsonConverters/TeamInfoJsonConverter.cs b/src/SteamWebAPI2/Utilities/JsonConverters/TeamInfoJsonConverter.cs
diff --git a/src/SteamWebAPI2/Utilities/JsonConverters/UnixTimeJsonConverter.cs b/src/SteamWebAPI2/Utilities/JsonConverters/UnixTimeJsonConverter.cs

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public SteamNews(string steamWebApiKey, ISteamWebInterface steamWebInterface = n`
`32`	`32`	`/// <returns></returns>`
`33`	`33`	`public async Task<ISteamWebResponse<SteamNewsResultModel>> GetNewsForAppAsync(uint appId, uint? maxLength = null, DateTime? endDate = null, uint? count = null)`
`34`	`34`	`{`
`35`		`- long? endDateUnixTimeStamp = null;`
	`35`	`+ ulong? endDateUnixTimeStamp = null;`
`36`	`36`
`37`	`37`	`if (endDate.HasValue)`
`38`	`38`	`{`
Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,8 @@ public async Task<ISteamWebResponse<IReadOnlyCollection<GlobalAchievementPercent`
`56`	`56`	`/// <returns></returns>`
`57`	`57`	`public async Task<ISteamWebResponse<IReadOnlyCollection<GlobalStatModel>>> GetGlobalStatsForGameAsync(uint appId, IReadOnlyList<string> statNames, DateTime? startDate = null, DateTime? endDate = null)`
`58`	`58`	`{`
`59`		`- long? startDateUnixTimeStamp = null;`
`60`		`- long? endDateUnixTimeStamp = null;`
	`59`	`+ ulong? startDateUnixTimeStamp = null;`
	`60`	`+ ulong? endDateUnixTimeStamp = null;`
`61`	`61`
`62`	`62`	`if (startDate.HasValue)`
`63`	`63`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace SteamWebAPI2.Models`
`6`	`6`	`internal class SteamApp`
`7`	`7`	`{`
`8`	`8`	`[JsonProperty("appid")]`
`9`		`- public int AppId { get; set; }`
	`9`	`+ public uint AppId { get; set; }`
`10`	`10`
`11`	`11`	`[JsonProperty("name")]`
`12`	`12`	`public string Name { get; set; }`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ internal class GlobalStatsForGameResult`
`17`	`17`	`public IList<GlobalStat> GlobalStats { get; set; }`
`18`	`18`
`19`	`19`	`[JsonProperty("result")]`
`20`		`- public int Status { get; set; }`
	`20`	`+ public uint Status { get; set; }`
`21`	`21`	`}`
`22`	`22`
`23`	`23`	`internal class GlobalStatsForGameResultContainer`