Skip to content

Commit 0a39373

Browse files
authored
fix order of generated event header handlers (#3361)
* fix random ordering of header codegen * regenerate
1 parent 098f389 commit 0a39373

3 files changed

Lines changed: 54 additions & 51 deletions

File tree

codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsEventStreamUtils.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static software.amazon.smithy.go.codegen.GoWriter.goTemplate;
44

5+
import java.util.Comparator;
56
import java.util.Map;
67
import java.util.Optional;
78
import java.util.Set;
@@ -1433,7 +1434,8 @@ public static void generateEventMessageSerializer(
14331434

14341435
var headerBindings = targetShape.members().stream()
14351436
.filter(memberShape -> memberShape.hasTrait(EventHeaderTrait.class))
1436-
.collect(Collectors.toSet());
1437+
.sorted(Comparator.comparing(MemberShape::getMemberName))
1438+
.collect(Collectors.toList());
14371439

14381440
var payloadBinding = targetShape.members().stream()
14391441
.filter(memberShape -> memberShape.hasTrait(EventPayloadTrait.class))
@@ -1662,7 +1664,8 @@ public static void generateEventMessageDeserializer(
16621664

16631665
var headerBindings = targetShape.members().stream()
16641666
.filter(memberShape -> memberShape.hasTrait(EventHeaderTrait.class))
1665-
.collect(Collectors.toSet());
1667+
.sorted(Comparator.comparing(MemberShape::getMemberName))
1668+
.collect(Collectors.toList());
16661669

16671670
var payloadBinding = targetShape.members().stream()
16681671
.filter(memberShape -> memberShape.hasTrait(EventPayloadTrait.class))

internal/protocoltest/awsrestjson/deserializers.go

Lines changed: 35 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/protocoltest/awsrestjson/serializers.go

Lines changed: 14 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)