feat: added captureHTTPsRequest feature - #677
Merged
Merged
Conversation
dreamorosi
requested review from
flochaz and
saragerion
and removed request for
flochaz
March 22, 2022 17:00
dreamorosi
marked this pull request as ready for review
March 22, 2022 17:00
dreamorosi
force-pushed
the
aamorosi/feat/tracer/add_capture_https
branch
from
March 23, 2022 09:07
6790faa to
c7ab458
Compare
Contributor
|
last force push might have removed all your changes ... I can't see diff anymore |
dreamorosi
force-pushed
the
aamorosi/feat/tracer/add_capture_https
branch
from
March 23, 2022 10:05
eb16898 to
f5736db
Compare
Contributor
Author
Contributor
Author
flochaz
reviewed
Mar 24, 2022
ijemmy
suggested changes
Mar 30, 2022
Contributor
Author
|
Thanks a ton @ijemmy for the review, agree with all your comments and I will address them right away. |
dreamorosi
force-pushed
the
aamorosi/feat/tracer/add_capture_https
branch
from
March 31, 2022 15:29
54bad38 to
05c20b9
Compare
flochaz
previously approved these changes
Apr 1, 2022
ijemmy
previously approved these changes
Apr 1, 2022
Co-authored-by: Florian Chazal <florianchazal@gmail.com>
dreamorosi
force-pushed
the
aamorosi/feat/tracer/add_capture_https
branch
from
April 1, 2022 11:29
646e5ff to
95cd754
Compare
Contributor
Author
|
Sorry, had to rebase due to merge conflicts :/ Need another round of reviews |
flochaz
previously approved these changes
Apr 1, 2022
saragerion
previously approved these changes
Apr 5, 2022
saragerion
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me already, great job!
Co-authored-by: Sara Gerion <47529391+saragerion@users.noreply.github.com>
Co-authored-by: Sara Gerion <47529391+saragerion@users.noreply.github.com>
Co-authored-by: Sara Gerion <47529391+saragerion@users.noreply.github.com>
flochaz
approved these changes
Apr 5, 2022
saragerion
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces a new feature for Tracer that allows to trace, by default, all outgoing HTTP(s) requests:
POWERTOOLS_TRACER_CAPTURE_HTTPS_REQUESTSenvironment variable orcaptureHTTPsRequestsconstructor parameter to false when instantiating the Traceraws-xray-sdkability to instrument the standard library'shttpandhttpsmodules, as Tracer should be able to trace any 3rd party request client library that is built upon these two modules. Support to 3rd party HTTP clients is provided on a best effort basis (this disclaimer is specified in the documentation).axioshas been tested during development and is included in integration tests.How to verify this change
See checks passing on this PR, see integration test results (link)
Screenshots of the new section in the documentation:

Documentation changes also include the addition of the new config to the Utility Settings section:

Screenshots of traces & service map generated by running this build & using


axios:Related issues, RFCs
#675
#275
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.