feat(commons): centralize cold start heuristic - #547
Merged
Conversation
This was referenced Feb 10, 2022
ijemmy
reviewed
Feb 11, 2022
ijemmy
left a comment
Contributor
There was a problem hiding this comment.
Only typo and grammar. This rest looks good.
Co-authored-by: ijemmy <ijemmy@users.noreply.github.com>
Co-authored-by: ijemmy <ijemmy@users.noreply.github.com>
ijemmy
approved these changes
Feb 14, 2022
saragerion
reviewed
Feb 16, 2022
|
|
||
| }); | ||
|
|
||
| test('when called multiple times on a child class, it returns true the first time, then false afterwards', () => { |
Contributor
There was a problem hiding this comment.
What would be the use case of testing the functionality from a child class?
Contributor
Author
There was a problem hiding this comment.
The other utilities (Tracer, Logger, etc.) will extend this Utility class and use it just like in this test case. I agree that it might be a little redundant but adding one test case was easier/faster than build+pack the new version of commons & install it in another package to test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces a new
Utilityclass in the@aws-lambda-powertools/commonspackage. This class is designed to be extended by other Powertools utilities that will inherit its shared methods.In this iteration the
Utilityclass brings a centralised cold start heuristic to be shared by all core packages.The changes in this PR have already been discussed in an internal RFC document reviewed by at least two other maintainers as per
CONTRIBUTINGguidelines.How to verify this change
Clone the repo & check newly introduced unit tests.
Also check the JSDoc documentation written in the class file.
Related issues, RFCs
#484
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.