fix(tracer): forward X-Amzn-Trace-Id header when instrumenting fetch - #3470
Merged
Conversation
boring-cyborg
Bot
added
tests
|
leandrodamascena
requested changes
Jan 14, 2025
leandrodamascena
left a comment
leandrodamascena
left a comment
Contributor
There was a problem hiding this comment.
Hi @dreamorosi! The TS implementations look good to me, the only thing is that it makes sense for us to check if it makes sense (and if it is possible) to keep the arbitrary fields.
am29d
approved these changes
Jan 14, 2025
leandrodamascena
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the implementation of the global fetch instrumentation in Tracer so that the
X-Amzn-Trace-Idheader is automatically populated and added to requests when Tracer is enabled.This allows X-Ray to attribute the segment/span to the correct parent and build the correct service map for a request.
Prior to this PR the header was not added and this resulted in disjointed traces. This happened only when using the Fetch API, but not when using the
httpsmodule - which is why this is considered a bug.The linked issue contains more info on why we did not add this in the first place and what was missing.
Issue number: fixes #3467
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.