feat(parser): add schema for DynamoDB - Kinesis Stream event - #3328
Conversation
…tions for DynamoDB stream events
…eam-events-via-Kinesis-Data-Stream
dreamorosi
left a comment
There was a problem hiding this comment.
I'll review this properly tomorrow morning, thanks for the PR.
When you get a chance, could you remove the unused imports flagged by SonarCloud?
…eam-events-via-Kinesis-Data-Stream
dreamorosi
left a comment
There was a problem hiding this comment.
Looking good, just a couple minor comments.
I have tested the schemas with a deployed DynamoDB table & Kinesis Stream and it works perfectly!
It's still a bit cumbersome to extend the DynamoDB item with your own schema because it's nested and because we don't have an helper to marshall the items (#3194), but we'll address these soon-ish.
Thank you!
…eam-events-via-Kinesis-Data-Stream
… structured clones
…eam-events-via-Kinesis-Data-Stream
dreamorosi
left a comment
There was a problem hiding this comment.
Thank you for the PR and for addressing my comments!
…eam-events-via-Kinesis-Data-Stream
|



Summary
This PR adds built-in schema for DynamoDB -> Kinesis -> Lambda event.
Changes
KinesisDynamoDBStreamschema with a dedicated record schemaI have decided to add a built-in schema, instead of the envelope because we already follow this convention with SQS-SNS, FireHose-SQS and other chained events.
I have decided not to change the
decompresslogic (only the typo), because I want to address this issue in a separate PR. There are various cases what can be wrapped into a Kinesis stream and I'd like to take a step back and see how we can create a better structure that will allow us to compose more easily.Issue number: closes #3193
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.