fix(logger): invalid time zone environment variables leads to error - #2865
Merged
dreamorosi merged 4 commits intoAug 1, 2024
Merged
Conversation
boring-cyborg
Bot
added
logger
dreamorosi
requested changes
Jul 31, 2024
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the quick PR, and great idea to test the value using existing libraries - I didn't know that method existed.
I've left one minor comment to make the code less verbose, but other than that it's looking good.
pull-request-size
Bot
added
size/S
dreamorosi
self-requested a review
August 1, 2024 14:39
|
dreamorosi
approved these changes
Aug 1, 2024
dreamorosi
left a comment
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Thank you for picking up the issue and fixing the bug!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
With this change the time zone argument for the
DateFormatin theLoggerutility is set toUTCwhenever the time zone from the environment variable is not supported (for example:/etc/localtime).Issue number: closes #2851
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.