fix(parser): handle API Gateway Test UI sourceIp - #2531
Merged
Conversation
boring-cyborg
Bot
added
parser
am29d
approved these changes
May 20, 2024
am29d
left a comment
am29d
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this edge case, this is definitely save troubles for future UI users!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the
APIGatewayProxyEventschema in the Parser utility to account for an edge case occurring when using the API Gateway Test UI to call an endpoint.In these cases API Gateway doesn't send a real
sourceIpbut instead sends a string hardcoded totest-invoke-source-ip. This caused the schema to fail parsing preventing customers from using the Test UI with endpoints using the Parser utility.Normally we wouldn't have made changes of this type, but since previous efforts to have the API Gateway service change this behavior have failed, and there's no workaround for customers, we are making an exception until the situation improves.
As of this PR the
sourceIpfield can be either a valid IP address or a string with valuetest-invoke-source-ip.Issue number: #2526
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.