feat(tracer): add try/catch logic to decorator and middleware close - #1716
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
Author
|
Passing integration tests: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/6328457720 |
am29d
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description of your changes
This PR introduces some
try/catchlogic to the parts of the code that are in charge of closing a subsegment in decorators and middleware usage.As reported in the linked issue, if the segment contains metadata that cannot be serialized calling the
subsegment.close()(orsubsegment.flush()) method will throw an error.This happens because the segment is serialized using
JSON.stringify()twice right before being emitted and so if the stringify method encounters an entity that doesn't know how to serialize, it'll throw an error.Even though the linked issue propsosed to add this
try/catchlogic to thetracer.putMetdata()method, this would be useless as the serialization is done just-in-time before emitting the segment.For this reason we must guard against runtime errors when closing the segment that we (Powertools) opened. In this case, we are now catching the error and logging a warning.
Customers can use this warning to:
It's important to note that this fix only safeguards against runtime errors for segments that Tracer opens under the hood. If customers try to call
segment.close()directly on a segment the error will still be thrown.We are attempting to work with the X-Ray team to provide a more permanent fix.
Related issues, RFCs
Issue number: #1713
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.