fix(parameters): return type when options without transform is used - #1671
Merged
dreamorosi merged 1 commit intoSep 4, 2023
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
dreamorosi
deleted the
1670-bug-secrets-manager-dynamodb-providers-incorrect-undefined-return-type
branch
September 4, 2023 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description of your changes
As discussed in the linked issue, when using the Parameters providers to retrieve values from Secrets Manager or DynamoDB and passing an options object with no
transformsetting, the return type of the value was mistakenly assigned toundefinedrather than the default return type for that provider.This PR fixes the issue by accounting for this case.
Related issues, RFCs
Issue number: #1670
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.