feat(logger): clear state when other middlewares return early - #1544
Merged
dreamorosi merged 1 commit intoJun 22, 2023
Conversation
2 tasks
Contributor
Author
|
Integration tests passing successfully: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/5345920515 |
am29d
approved these changes
Jun 22, 2023
am29d
left a comment
Contributor
There was a problem hiding this comment.
super clean, thanks to the previous work 👍
dreamorosi
marked this pull request as draft
June 22, 2023 14:16
dreamorosi
marked this pull request as ready for review
June 22, 2023 14:26
dreamorosi
deleted the
1534-feature-request-populate-middys-requestinternal-with-cleanup-function-for-logger
branch
June 22, 2023 14:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces new logic to the
injectLambdaContext()Middy middleware offered by Logger to allow it to clean its state whenever another middleware down in the stack returns early.This is made possible by the
cleanupMiddlewaresfunction shipped incommonsin the previous release. The new logic sets a reference to a cleanup function in the Middy internal storage using a scoped key. This way, Middy middlewares that want to return early can call thecleanupMiddlewaresfunction which will execute all the cleanup functions available. This is useful for those middlewares like Idempotency, that want to return a result bypassing the Lambda handler and the normal Middy request lifecycle.I have also added a unit test case to verify that the cleanup logic is executed.
Related issues, RFCs
Issue number: #1534
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.