fix(logger): fix a bug when child logger didn't get all the parent's attributes

[shdq]

When createChild create a child logger without options, it didn't inherit the parents' attributes.

Attributes affected:

• logLevel
• customConfigService
• logFormatter

Example:

// With this logger, all the INFO logs will be printed
const logger = new Logger({
    logLevel: 'INFO'
});

// With this logger, we expect INFO logs too
const childLogger = parentLogger.createChild();

But it will be DEBUG since it is the default value:

-   "logLevel": "INFO",
+   "logLevel": "DEBUG",

Description of your changes

Missing parent's attributes are added to options before merging with child options that suppose to overwrite them.

It was missed because existing tests compare attributes against default values. I added a test with all possible parent's options with non-default values and found all the affected attributes.

How to verify this change

Related issues, RFCs

Issue number: #1264

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

• My changes meet the tenets criteria
• I have performed a self-review of my own code
• I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding changes to the examples
• My changes generate no new warnings
• The code coverage hasn't decreased
• I have added tests that prove my change is effective and works
• New and existing unit tests pass locally and in Github Actions
• Any dependent changes have been merged and published
• The PR title follows the conventional commit semantics

Breaking change checklist

• I have documented the migration process
• I have added, implemented necessary warnings (if it can live side by side)

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[saragerion]

Thanks for opening this PR. We have a number of other items high on priority before we can look into this issue and verify this PR, but we'll get back to you.

[shdq]

Hi @saragerion, thank you for the reply!

That is great that test failed in CI because I ran it locally several times, and it was passed. I revisited the code, and since logsSampled value depends on the random function (see setLogsSampled() method in Loggerclass) test finishes with different results. I adjusted the test and made a minor change to the implementation.

[dreamorosi]

Thank you @shdq for the bias for action on this PR.

I've run the integration tests on this branch and they are passing.

Let's go!

[danrivett]

I just ran into this issue with child loggers not inheriting the parent's logLevel, so thanks for fixing this, it's much appreciated.

If I'm correct, it looks like it should be released as part of an upcoming 1.6.0 version, so looking forward to migrating to that once published.

[danrivett]

I can confirm that we upgraded to 1.6.0 today and it fixed our child logLevel issue perfectly 🎉 Thank you!

[dreamorosi]

Indeed, we have just released the new version and the issue should be fixed.

Happy to hear, thank you for following up!

[shdq]

I'm glad to hear that. Thank you for the feedback!