feat: publish lib as Lambda Layer - #1095
Merged
Merged
Conversation
flochaz
marked this pull request as ready for review
October 3, 2022 05:21
flochaz
requested review from
dreamorosi,
ijemmy and
saragerion
and removed request for
dreamorosi and
ijemmy
October 3, 2022 05:21
dreamorosi
previously approved these changes
Oct 3, 2022
dreamorosi
left a comment
Contributor
There was a problem hiding this comment.
Great work Florian, thank you fro this PR.
I've left only a couple of minor comments but it's already looking good.
| BuildMethod: esbuild | ||
| BuildProperties: | ||
| Minify: true | ||
| External:s |
Contributor
There was a problem hiding this comment.
Is this s in External:s (<- this) on purpose? If yes please resolve this comment.
dreamorosi
previously approved these changes
Oct 3, 2022
Contributor
Author
|
Docker dependency might be an overkill, thinking about moving to a simple zip bundling: |
dreamorosi
approved these changes
Oct 4, 2022
ijemmy
approved these changes
Oct 6, 2022
|
|
||
| ## Switch to Lambda Layer | ||
|
|
||
| This example bundle all your dependencies in a single JS file thanks to esbuild but you can switch the AWSLambdaPowertoolsTypeScript Layer by: |
Contributor
There was a problem hiding this comment.
Suggested change
| This example bundle all your dependencies in a single JS file thanks to esbuild but you can switch the AWSLambdaPowertoolsTypeScript Layer by: | |
| This example bundles all your dependencies in a single JS file with `esbuild`. You can switch the `AWSLambdaPowertoolsTypeScript` Layer by: |
Contributor
|
@awslabs/aws-lambda-powertools-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
How to verify this change
Release process: https://github.com/awslabs/aws-lambda-powertools-typescript/actions/runs/2826141922
A public version is already available under this ARN:
arn:aws:lambda:{REGION}:094274105915:layer:AWSLambdaPowertoolsTypeScript:1that was published during1.0.2release. So can be used in any deployment. An example of its usage is available in our CDK examples and be deploy simply:Get to your AWS Console lambda , select the Lambda called
MyLayeredFunctionand check it's code and execution.E2E tests has been added in the layer publisher as well.
Related issues, RFCs
#826
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.