fix(commons): rename AvailabilityZoneId to AvailabilityZoneID in docs and tests (#5118)

Author: svozza

docs/features/metadata.md

@@ -34,7 +34,7 @@ You can fetch data from the LMDS using the `getMetadata` function. For example,
 
 | Property             | Type     | Description                                             |
 | -------------------- | -------- | ------------------------------------------------------- |
-| `AvailabilityZoneId` | `string` | The AZ where the function is running (e.g., `use1-az1`) |
+| `AvailabilityZoneID` | `string` | The AZ where the function is running (e.g., `use1-az1`) |
 
 ## Testing your code
 

examples/snippets/commons/metadata.ts

@@ -5,6 +5,6 @@ const logger = new Logger({ serviceName: 'serverlessAirline' });
 const metadata = await getMetadata();
 
 export const handler = async () => {
-  const { AvailabilityZoneId: azId } = metadata;
+  const { AvailabilityZoneID: azId } = metadata;
   logger.appendKeys({ azId });
 };

packages/commons/tests/unit/metadata.test.ts

@@ -46,7 +46,7 @@ describe('Function: getMetadata', () => {
     vi.stubEnv('AWS_LAMBDA_METADATA_API', '127.0.0.1:1234');
     vi.stubEnv('AWS_LAMBDA_METADATA_TOKEN', 'test-token');
 
-    const payload = { AvailabilityZoneId: 'use1-az1' };
+    const payload = { AvailabilityZoneID: 'use1-az1' };
     fetchMock.mockResolvedValue({
       ok: true,
       json: vi.fn().mockResolvedValue(payload),
@@ -82,7 +82,7 @@ describe('Function: getMetadata', () => {
       .spyOn(AbortSignal, 'timeout')
       .mockReturnValue(new AbortController().signal);
 
-    const payload = { AvailabilityZoneId: 'use1-az1' };
+    const payload = { AvailabilityZoneID: 'use1-az1' };
     fetchMock.mockResolvedValue({
       ok: true,
       json: vi.fn().mockResolvedValue(payload),