Skip to content

fix: keep rs inormer updated upon updating labels and annotations - #3321

Merged
zachaller merged 2 commits into
argoproj:masterfrom
zachaller:keep-rs-informer-updated
Jan 24, 2024
Merged

fix: keep rs inormer updated upon updating labels and annotations#3321
zachaller merged 2 commits into
argoproj:masterfrom
zachaller:keep-rs-informer-updated

Conversation

@zachaller

@zachaller zachaller commented Jan 22, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@zachaller
fix: keep rs inormer updated upon updating labels and annotations
d1fa1bf 
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@github-actions

github-actions Bot commented Jan 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 25fbf8d.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jan 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

E2E Tests Published Test Results

  4 files    4 suites   3h 28m 24s ⏱️
106 tests  98 ✅  6 💤  2 ❌
440 runs  400 ✅ 24 💤 16 ❌

For more details on these failures, see this check.

Results for commit 25fbf8d.

♻️ This comment has been updated with latest results.

@zachaller
give error some context
25fbf8d 
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@sonarqubecloud

sonarqubecloud Bot commented Jan 23, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

@codecov

codecov Bot commented Jan 23, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (180b4bf) 81.83% compared to head (25fbf8d) 81.82%.
Report is 4 commits behind head on master.

Files Patch % Lines
rollout/ephemeralmetadata.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
- Coverage   81.83%   81.82%   -0.02%     
==========================================
  Files         135      135              
  Lines       20633    20637       +4     
==========================================
+ Hits        16885    16886       +1     
- Misses       2877     2879       +2     
- Partials      871      872       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leoluz
leoluz approved these changes Jan 24, 2024
View reviewed changes

@leoluz leoluz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller
zachaller merged commit 07355a0 into argoproj:master Jan 24, 2024
zachaller added a commit that referenced this pull request Jan 24, 2024
@zachaller
fix: keep rs inormer updated upon updating labels and annotations (#3321
eded8a1 
)

* fix: keep rs inormer updated upon updating labels and annotations

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* give error some context

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leoluz leoluz leoluz approved these changes

Assignees

No one assigned

Labels

cherry-pick/release-1.6 cherry-pick-completed Used once we have cherry picked the PR to all requested releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zachaller @leoluz