fix: updates to replicas and pod template at the same time causes rollout to get stuck - #3272
Merged
zachaller merged 3 commits intoJan 2, 2024
Conversation
Contributor
Go Published Test Results2 093 tests 2 093 ✅ 2m 49s ⏱️ Results for commit 085cb4b. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3272 +/- ##
=======================================
Coverage 81.83% 81.83%
=======================================
Files 135 135
Lines 20629 20633 +4
=======================================
+ Hits 16881 16885 +4
Misses 2877 2877
Partials 871 871 ☔ View full report in Codecov by Sentry. |
zachaller
changed the title
Contributor
E2E Tests Published Test Results 4 files 4 suites 3h 27m 5s ⏱️ For more details on these failures, see this check. Results for commit 085cb4b. ♻️ This comment has been updated with latest results. |
zachaller
changed the title
Contributor
|
this works! when will this merge? @zachaller |
Contributor
|
@zachaller when will this be merged? |
…ry strategy. Signed-off-by: Liming Liu <andyliuliming@outlook.com>
Signed-off-by: Liming Liu <andyliuliming@outlook.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
force-pushed
the
fixreplicapodchangetogether-status
branch
from
December 29, 2023 15:01
b10e305 to
085cb4b
Compare
zachaller
marked this pull request as ready for review
December 29, 2023 15:01
|
leoluz
reviewed
Jan 2, 2024
zachaller
added a commit
that referenced
this pull request
Jan 2, 2024
…lout to get stuck (#3272) * fix: fix the rollout stuck when pod/replicas changed together or canary strategy. Signed-off-by: Liming Liu <andyliuliming@outlook.com> * add one unit test case for empty canary service. Signed-off-by: Liming Liu <andyliuliming@outlook.com> * use rollout status to get the replicaset hash instead of service Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Liming Liu <andyliuliming@outlook.com> Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> Co-authored-by: Liming Liu <andyliuliming@outlook.com>
zachaller
added
the
cherry-pick-completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #3256
The rollout status is updated here