fix: resolve args to metric in garbage collection function - #2843
Merged
Conversation
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
force-pushed
the
fix-resolveargs-for-gc
branch
from
June 14, 2023 18:17
6620c1b to
1514a95
Compare
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
force-pushed
the
fix-resolveargs-for-gc
branch
from
June 14, 2023 19:17
1514a95 to
879462a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2843 +/- ##
==========================================
- Coverage 81.67% 81.66% -0.02%
==========================================
Files 133 133
Lines 20188 20192 +4
==========================================
+ Hits 16489 16490 +1
- Misses 2847 2849 +2
- Partials 852 853 +1
☔ View full report in Codecov by Sentry. |
Contributor
Contributor
leoluz
reviewed
Jun 15, 2023
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
enabled auto-merge (squash)
June 15, 2023 15:48
zachaller
disabled auto-merge
June 15, 2023 15:48
zachaller
enabled auto-merge (squash)
June 15, 2023 15:48
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
added a commit
that referenced
this pull request
Jun 15, 2023
* resolve args to metric in garbage collection function Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove incorrectly added test, this moved to a function Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-trigger Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add context to errors Signed-off-by: zachaller <zachaller@users.noreply.github.com> * better error message Signed-off-by: zachaller <zachaller@users.noreply.github.com> * better error message Signed-off-by: zachaller <zachaller@users.noreply.github.com> --------- Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we resolve args before creating the provider for garbage collection, this lets providers such as prometheus check that the url is valid if it contains any args.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".