fix(analysis): Graphite metric provider - index out of range [0] with length 0 - #2751
Merged
Conversation
… length 0 Signed-off-by: mdsjip <2284562+mdsjip@users.noreply.github.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2751 +/- ##
=======================================
Coverage 81.62% 81.63%
=======================================
Files 133 133
Lines 20157 20160 +3
=======================================
+ Hits 16454 16457 +3
Misses 2849 2849
Partials 854 854
☔ View full report in Codecov by Sentry. |
Contributor
Contributor
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Rare case, but seen in the wild: Graphite APIs returning response body with just an empty array:
[]This PR allows to handle this case by checking it and returning an empty
dataPointarray.Checklist:
"fix(controller): Updates such and such. Fixes #1234".