Skip to content

chore: update e2e k8s versions - #2637

Merged
zachaller merged 2 commits into
argoproj:masterfrom
zachaller:chore-update-e2e-k8s-versions
Mar 13, 2023
Merged

chore: update e2e k8s versions#2637
zachaller merged 2 commits into
argoproj:masterfrom
zachaller:chore-update-e2e-k8s-versions

Conversation

@zachaller

@zachaller zachaller commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

run e2e tests on more current k8s versions, going forward 4 will be the most we support and will start dropping older versions.

I also updated the crd's from their upstreams for e2e tests.

I also fixed a bug with the tmate logic on manual runs, an empty string passes as true on actions and so we would always fall into debug mode.

@github-actions

github-actions Bot commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Go Published Test Results

1 871 tests   1 871 ✔️  2m 30s ⏱️
   118 suites         0 💤
       1 files           0

Results for commit 360bf8b.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Mar 3, 2023

Copy link
Copy Markdown

Codecov Report

Patch and project coverage have no change.

Comparison is base (5318977) 81.50% compared to head (c211c6b) 81.50%.

❗ Current head c211c6b differs from pull request most recent head 360bf8b. Consider uploading reports for the commit 360bf8b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2637   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files         133      133           
  Lines       19852    19852           
=======================================
  Hits        16181    16181           
  Misses       2836     2836           
  Partials      835      835           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

E2E Tests Published Test Results

    4 files      4 suites   3h 7m 46s ⏱️
  94 tests   83 ✔️   5 💤 6
382 runs  356 ✔️ 20 💤 6

For more details on these failures, see this check.

Results for commit 360bf8b.

♻️ This comment has been updated with latest results.

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller
zachaller force-pushed the chore-update-e2e-k8s-versions branch from c211c6b to 360bf8b Compare March 3, 2023 17:54
@sonarqubecloud

sonarqubecloud Bot commented Mar 3, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

@leoluz leoluz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller
zachaller merged commit b1a1e15 into argoproj:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants