feat(controller): Adding status.alb.canaryTargetGroup.fullName for ALB. Fixes #2589 - #2604
Merged
Merged
Conversation
danil-smirnov
force-pushed
the
status-alb-fix
branch
from
February 18, 2023 09:24
f02d1e3 to
fd7b647
Compare
Contributor
Contributor
danil-smirnov
force-pushed
the
status-alb-fix
branch
2 times, most recently
from
February 18, 2023 10:51
4b733b4 to
857022a
Compare
2 tasks
danil-smirnov
force-pushed
the
status-alb-fix
branch
4 times, most recently
from
February 21, 2023 10:18
b9ae003 to
1fe56c0
Compare
Codecov ReportBase: 81.52% // Head: 81.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2604 +/- ##
==========================================
+ Coverage 81.52% 81.53% +0.01%
==========================================
Files 131 131
Lines 19562 19578 +16
==========================================
+ Hits 15947 15963 +16
Misses 2795 2795
Partials 820 820
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Danil Smirnov <danil@smirnov.la>
Signed-off-by: Danil Smirnov <danil@smirnov.la>
Signed-off-by: Danil Smirnov <danil@smirnov.la>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: Danil Smirnov <danil@smirnov.la>
Signed-off-by: Danil Smirnov <danil@smirnov.la>
danil-smirnov
force-pushed
the
status-alb-fix
branch
from
February 21, 2023 20:18
599469f to
3e4a397
Compare
zachaller
requested changes
Feb 21, 2023
Signed-off-by: Danil Smirnov <danil@smirnov.la>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
changed the title
zachaller
approved these changes
Feb 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2589
Checklist:
"fix(controller): Updates such and such. Fixes #1234".