Skip to content

chore: fix typo for json tag on rollbackWindow - #2598

Merged
zachaller merged 1 commit into
argoproj:masterfrom
zachaller:fix-typo-on-rollbackwindow
Feb 16, 2023
Merged

chore: fix typo for json tag on rollbackWindow#2598
zachaller merged 1 commit into
argoproj:masterfrom
zachaller:fix-typo-on-rollbackwindow

Conversation

@zachaller

Copy link
Copy Markdown
Collaborator

fixes: #2568

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.3% 2.3% Duplication

@zachaller
zachaller requested a review from leoluz February 16, 2023 21:15

@leoluz leoluz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

Go Published Test Results

1 850 tests   1 850 ✔️  2m 30s ⏱️
   112 suites         0 💤
       1 files           0

Results for commit c714cc9.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 44m 27s ⏱️
  96 tests   85 ✔️ 3 💤 8
200 runs  186 ✔️ 6 💤 8

For more details on these failures, see this check.

Results for commit c714cc9.

@zachaller
zachaller merged commit 4afac4e into argoproj:master Feb 16, 2023
chatchai-outreach pushed a commit to getoutreach/argoproj-argo-rollouts that referenced this pull request Feb 21, 2023
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@zachaller zachaller added cherry-pick/release-1.4 cherry-pick-completed Used once we have cherry picked the PR to all requested releases labels Feb 24, 2023
zachaller added a commit that referenced this pull request Feb 24, 2023
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-1.4 cherry-pick-completed Used once we have cherry picked the PR to all requested releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argo Rollout RollbackWindow property is NOT optional as documented.

2 participants