fix: support only tls in virtual services - #2502
Merged
Merged
Conversation
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Contributor
Contributor
Codecov ReportBase: 81.68% // Head: 81.70% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
+ Coverage 81.68% 81.70% +0.01%
==========================================
Files 126 126
Lines 19132 19135 +3
==========================================
+ Hits 15628 15634 +6
+ Misses 2710 2708 -2
+ Partials 794 793 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
harikrongali
approved these changes
Dec 28, 2022
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
agrawroh
reviewed
Dec 29, 2022
agrawroh
reviewed
Dec 29, 2022
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
agrawroh
approved these changes
Dec 29, 2022
agrawroh
left a comment
agrawroh
left a comment
Member
There was a problem hiding this comment.
—— SHIP IT ——
,:',:`,:'
__||_||_||_||__
____["""""""""""""""]____
\ " '''''''''''''''''''' |
~^~~^~^~^^~^~^~^~^~^~^~^~~^~^~^^~~^~^
leoluz
approved these changes
Jan 3, 2023
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
added a commit
that referenced
this pull request
Jan 4, 2023
* fix: support only tls in virtual services Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix typo Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add test file Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add unit test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove /n Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-ran codegen Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-run codegen for 2023 Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added a commit
that referenced
this pull request
Jan 4, 2023
* fix: support only tls in virtual services Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix typo Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add test file Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add unit test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove /n Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-ran codegen Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-run codegen for 2023 Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com>
zachaller
added
the
cherry-pick-completed
tperdue321
pushed a commit
to rallyhealth/argo-rollouts
that referenced
this pull request
Jan 12, 2023
* fix: support only tls in virtual services Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix typo Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add test file Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add unit test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove /n Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-ran codegen Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-run codegen for 2023 Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321
pushed a commit
to rallyhealth/argo-rollouts
that referenced
this pull request
Jan 12, 2023
* fix: support only tls in virtual services Signed-off-by: zachaller <zachaller@users.noreply.github.com> * fix typo Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add test file Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add unit test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * cleanup test Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * improve comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> * remove /n Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-ran codegen Signed-off-by: zachaller <zachaller@users.noreply.github.com> * re-run codegen for 2023 Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2501
Signed-off-by: zachaller zachaller@users.noreply.github.com