Skip to content

docs: fix typo in helm Argo rollouts - #2442

Merged
zachaller merged 2 commits into
argoproj:masterfrom
alecrajeev:fix-docs-typo
Nov 30, 2022
Merged

docs: fix typo in helm Argo rollouts#2442
zachaller merged 2 commits into
argoproj:masterfrom
alecrajeev:fix-docs-typo

Conversation

@alecrajeev

Copy link
Copy Markdown
Contributor

fixing docs typo in Helm Argo Rollouts. Instal -> Install

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@alecrajeev
alecrajeev force-pushed the fix-docs-typo branch 2 times, most recently from 1c96200 to 41d3b5d Compare November 29, 2022 22:28
fixing docs typo

Signed-off-by: Alec Rajeev <13004609+alecrajeev@users.noreply.github.com>
Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>
@github-actions

github-actions Bot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Go Published Test Results

1 800 tests   1 800 ✔️  2m 29s ⏱️
   102 suites         0 💤
       1 files           0

Results for commit a30f812.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Nov 29, 2022

Copy link
Copy Markdown

Codecov Report

Base: 81.58% // Head: 81.58% // No change to project coverage 👍

Coverage data is based on head (a30f812) compared to base (3342427).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2442   +/-   ##
=======================================
  Coverage   81.58%   81.58%           
=======================================
  Files         124      124           
  Lines       18959    18959           
=======================================
  Hits        15467    15467           
  Misses       2702     2702           
  Partials      790      790           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

github-actions Bot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 33m 34s ⏱️
  92 tests   84 ✔️ 3 💤 5
192 runs  179 ✔️ 6 💤 7

For more details on these failures, see this check.

Results for commit a30f812.

♻️ This comment has been updated with latest results.

Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Gallardot Gallardot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller
zachaller merged commit 5a1cc74 into argoproj:master Nov 30, 2022
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* docs: fix typo

fixing docs typo

Signed-off-by: Alec Rajeev <13004609+alecrajeev@users.noreply.github.com>
Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>

* fix link

Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>

Signed-off-by: Alec Rajeev <13004609+alecrajeev@users.noreply.github.com>
Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* docs: fix typo

fixing docs typo

Signed-off-by: Alec Rajeev <13004609+alecrajeev@users.noreply.github.com>
Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>

* fix link

Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>

Signed-off-by: Alec Rajeev <13004609+alecrajeev@users.noreply.github.com>
Signed-off-by: Alec Rajeev <ccarajeev342@gmail.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants