Skip to content

chore: rename the examples/trafffic-routing directory to istio - #2315

Merged
zachaller merged 1 commit into
argoproj:masterfrom
iam-veeramalla:docs
Nov 7, 2022
Merged

chore: rename the examples/trafffic-routing directory to istio#2315
zachaller merged 1 commit into
argoproj:masterfrom
iam-veeramalla:docs

Conversation

@iam-veeramalla

Copy link
Copy Markdown
Member

Signed-off-by: iam-veeramalla abhishek.veeramalla@gmail.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • [] My organization is added to USERS.md.

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iam-veeramalla

iam-veeramalla commented Oct 12, 2022

Copy link
Copy Markdown
Member Author

@zachaller do you think this makes sense ?
I am not sure about the intention behind adding folder name as traffic-routing but currently it just has istio-host-based-splitting example manifest and everything else such as ALB, Ambassador are outside this folder.

Having a dedicated folder for istio provides a better attention for who ever is looking for trying out rollouts with istio. We can keep adding istio examples in this folder.

@github-actions

Copy link
Copy Markdown
Contributor

Go Published Test Results

1 772 tests   1 772 ✔️  2m 34s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit d9c0420.

@codecov

codecov Bot commented Oct 12, 2022

Copy link
Copy Markdown

Codecov Report

Base: 82.38% // Head: 82.38% // No change to project coverage 👍

Coverage data is based on head (d9c0420) compared to base (1394f4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2315   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         121      121           
  Lines       18476    18476           
=======================================
  Hits        15221    15221           
  Misses       2468     2468           
  Partials      787      787           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Tests Published Test Results

  1 files    1 suites   51m 27s ⏱️
89 tests 82 ✔️ 3 💤 4
97 runs  86 ✔️ 3 💤 8

For more details on these failures, see this check.

Results for commit d9c0420.

@iam-veeramalla iam-veeramalla changed the title chore: rename the examples/trafffic-management directory to istio chore: rename the examples/trafffic-routing directory to istio Oct 12, 2022
@zachaller

zachaller commented Oct 13, 2022

Copy link
Copy Markdown
Collaborator

traffic-routing

I like traffic-routing-istio I think that way we would group all the traffic routers together in the list. Aka then we should be able to add say have traffic-router-ambassador etc.

@zachaller

Copy link
Copy Markdown
Collaborator

Actually I think I like just istio after thinking about it more.

@zachaller zachaller added the ready-for-review Ready for final review label Oct 13, 2022
@zachaller
zachaller merged commit 0a77c33 into argoproj:master Nov 7, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
…goproj#2315)

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
…goproj#2315)

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>

Signed-off-by: iam-veeramalla <abhishek.veeramalla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants