fix(example): correct docs when metrics got result empty by hungran · Pull Request #2309 · argoproj/argo-rollouts

hungran · 2022-10-11T04:40:22Z

Checklist:

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

Bumps [github.com/newrelic/newrelic-client-go](https://github.com/newrelic/newrelic-client-go) from 0.86.5 to 1.0.0. - [Release notes](https://github.com/newrelic/newrelic-client-go/releases) - [Changelog](https://github.com/newrelic/newrelic-client-go/blob/main/CHANGELOG.md) - [Commits](newrelic/newrelic-client-go@v0.86.5...v1.0.0) --- updated-dependencies: - dependency-name: github.com/newrelic/newrelic-client-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

github-actions · 2022-10-11T04:59:36Z

Go Published Test Results

1 791 tests 1 791 ✔️ 2m 31s ⏱️
  101 suites       0 💤
      1 files       0 ❌

Results for commit 4c77fa7.

♻️ This comment has been updated with latest results.

codecov · 2022-10-11T05:00:45Z

Codecov Report

Base: 81.54% // Head: 82.76% // Increases project coverage by +1.22% 🎉

Coverage data is based on head (a3b7ad6) compared to base (75b7a6e).
Patch has no changes to coverable lines.

❗ Current head a3b7ad6 differs from pull request most recent head 4c77fa7. Consider uploading reports for the commit 4c77fa7 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
+ Coverage   81.54%   82.76%   +1.22%     
==========================================
  Files         123      121       -2     
  Lines       18870    18536     -334     
==========================================
- Hits        15387    15341      -46     
+ Misses       2696     2410     -286     
+ Partials      787      785       -2

Impacted Files	Coverage Δ
utils/template/template.go	`100.00% <0.00%> (ø)`
server/server.go
server/server_static.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

github-actions · 2022-10-11T05:26:11Z

E2E Tests Published Test Results

    2 files     2 suites 1h 32m 53s ⏱️
  89 tests   84 ✔️ 3 💤 2 ❌
180 runs 172 ✔️ 6 💤 2 ❌

For more details on these failures, see this check.

Results for commit 4c77fa7.

♻️ This comment has been updated with latest results.

iam-veeramalla · 2022-10-18T12:50:14Z

Hi @hungran, This PR is also upgrading the versions in go.mod and go.sum, I think it is not intended. Can you PTAL and rebase the PR ?

hungran · 2022-10-27T16:51:01Z

Hey @iam-veeramalla thanks for your notice, I made rebase already

iam-veeramalla

LGTM

…an-patch-1 Signed-off-by: zachaller <zachaller@users.noreply.github.com>

sonarqubecloud · 2022-11-08T15:12:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.0% Duplication

* chore(deps): bump github.com/newrelic/newrelic-client-go (argoproj#2267) Bumps [github.com/newrelic/newrelic-client-go](https://github.com/newrelic/newrelic-client-go) from 0.86.5 to 1.0.0. - [Release notes](https://github.com/newrelic/newrelic-client-go/releases) - [Changelog](https://github.com/newrelic/newrelic-client-go/blob/main/CHANGELOG.md) - [Commits](newrelic/newrelic-client-go@v0.86.5...v1.0.0) --- updated-dependencies: - dependency-name: github.com/newrelic/newrelic-client-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> * fix: correct docs when metrics got result empty Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: hungran <26101787+hungran@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zachaller <zachaller@users.noreply.github.com>

hungran force-pushed the patch-1 branch from 887eff9 to b64ee05 Compare October 11, 2022 04:48

dependabot Bot and others added 2 commits October 11, 2022 11:48

fix: correct docs when metrics got result empty

4806a62

Signed-off-by: hungran <26101787+hungran@users.noreply.github.com>

hungran force-pushed the patch-1 branch from b64ee05 to 4806a62 Compare October 11, 2022 04:50

hungran changed the title ~~fix: correct docs when metrics got result empty~~ fix(docs): correct docs when metrics got result empty Oct 11, 2022

iam-veeramalla self-requested a review October 18, 2022 12:50

iam-veeramalla added the docs Needs documentation/release notes label Oct 18, 2022

hungran closed this Oct 21, 2022

hungran force-pushed the patch-1 branch from 4806a62 to 9fee037 Compare October 21, 2022 03:58

Merge remote-tracking branch 'upstream/master' into patch-1

141f938

hungran reopened this Oct 21, 2022

hungran changed the title ~~fix(docs): correct docs when metrics got result empty~~ fix(example): correct docs when metrics got result empty Oct 21, 2022

iam-veeramalla approved these changes Oct 27, 2022

View reviewed changes

iam-veeramalla added the ready-for-review Ready for final review label Oct 27, 2022

Merge branch 'master' into patch-1

a3b7ad6

hungran requested a review from iam-veeramalla November 1, 2022 07:22

zachaller approved these changes Nov 8, 2022

View reviewed changes

Merge branch 'patch-1' of github.com:hungran/argo-rollouts into hungr…

4c77fa7

…an-patch-1 Signed-off-by: zachaller <zachaller@users.noreply.github.com>

zachaller force-pushed the patch-1 branch from a373143 to 4c77fa7 Compare November 8, 2022 15:11

zachaller merged commit 97ed6de into argoproj:master Nov 8, 2022

Navigation Menu

Uh oh!

fix(example): correct docs when metrics got result empty - #2309

fix(example): correct docs when metrics got result empty#2309
zachaller merged 5 commits into
argoproj:masterfrom
hungran:patch-1

hungran commented Oct 11, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 11, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Oct 11, 2022 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 11, 2022 •

edited

Loading

Uh oh!

iam-veeramalla commented Oct 18, 2022

Uh oh!

hungran commented Oct 27, 2022

Uh oh!

iam-veeramalla left a comment

Uh oh!

sonarqubecloud Bot commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

hungran commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Go Published Test Results

Uh oh!

codecov Bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Oct 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Tests Published Test Results

Uh oh!

iam-veeramalla commented Oct 18, 2022

Uh oh!

hungran commented Oct 27, 2022

Uh oh!

iam-veeramalla left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hungran commented Oct 11, 2022 •

edited

Loading

github-actions Bot commented Oct 11, 2022 •

edited

Loading

codecov Bot commented Oct 11, 2022 •

edited

Loading

github-actions Bot commented Oct 11, 2022 •

edited

Loading