Skip to content

fix: remove symbolize#413

Merged
KazuCocoa merged 2 commits into
masterfrom
remove-symbolize
Oct 9, 2022
Merged

fix: remove symbolize#413
KazuCocoa merged 2 commits into
masterfrom
remove-symbolize

Conversation

@KazuCocoa

@KazuCocoa KazuCocoa commented Oct 9, 2022

Copy link
Copy Markdown
Member

fixes appium/ruby_lib#945

Removes Appium.symbolize_keys which makes capability keys to symbol forcefully.

The code was copied from legacy ruby_lib code to ruby_lib_core. I was not sure the root motivation for that, but now ruby_lib_core converts capability keys which does not have appium: as string.

@KazuCocoa KazuCocoa changed the title fix: remove symbolize since it no makes sense fix: remove symbolize Oct 9, 2022
@KazuCocoa KazuCocoa merged commit 2f888e7 into master Oct 9, 2022
@KazuCocoa KazuCocoa deleted the remove-symbolize branch October 9, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keys provided as string in caps being converted to camel case from snake case since selenium v4 base

1 participant