Skip to content

Commit f4d2f4a

Browse files
chore(ci): update the node versions that we are testing to fix failin… (#3364)
chore: drop Node.js 14/16 support, require Node.js 18+ - Update CI to test against Node.js 18, 20, 22, 24, and latest - Remove npm@9 install step (no longer needed without Node 14) - Update engines field in package.json files to require Node.js >=18 - Bump npm version constraint from <11 to <12 Co-authored-by: Duckki Oe <duckki.oe@apollographql.com>
1 parent 036b455 commit f4d2f4a

6 files changed

Lines changed: 19 additions & 10 deletions

File tree

.changeset/brave-sails-study.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
---
2+
"apollo-federation-integration-testsuite": minor
3+
"@apollo/query-planner": minor
4+
"@apollo/query-graphs": minor
5+
"@apollo/composition": minor
6+
"@apollo/federation-internals": minor
7+
"@apollo/subgraph": minor
8+
"@apollo/gateway": minor
9+
---
10+
11+
- Drop Node.js 14/16 support, require Node.js 18+
12+

.circleci/config.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ jobs:
1818
- checkout
1919
- node/install:
2020
node-version: << parameters.node-version >>
21-
# node v14 defaults to npm 6, which is too old for our package-lock.json
22-
# should be able to remove this step when we drop node v14
23-
- run: npm install -g npm@9
2421
- node/install-packages
2522
- run:
2623
name: Run tests
@@ -57,11 +54,11 @@ workflows:
5754
matrix:
5855
parameters:
5956
node-version:
60-
- "14"
61-
- "16"
6257
- "18"
6358
- "20"
6459
- "22"
60+
- "24"
61+
- "latest"
6562
- Lint:
6663
name: Lint - << matrix.script >>
6764
matrix:

composition-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"author": "Apollo <packages@apollographql.com>",
2222
"license": "Elastic-2.0",
2323
"engines": {
24-
"node": ">=14.15.0"
24+
"node": ">=18"
2525
},
2626
"publishConfig": {
2727
"access": "public"

internals-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"author": "Apollo <packages@apollographql.com>",
2121
"license": "Elastic-2.0",
2222
"engines": {
23-
"node": ">=14.15.0"
23+
"node": ">=18"
2424
},
2525
"dependencies": {
2626
"chalk": "^4.1.0",

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@
3434
"git:configure": "git config core.hooksPath .git-hooks; git config blame.ignoreRevsFile .git-blame-ignore-revs"
3535
},
3636
"engines": {
37-
"node": ">=14.15.0",
38-
"npm": "<=11"
37+
"node": ">=18",
38+
"npm": "<12"
3939
},
4040
"workspaces": [
4141
"internals-js",

query-graphs-js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"author": "Apollo <packages@apollographql.com>",
2121
"license": "Elastic-2.0",
2222
"engines": {
23-
"node": ">=14.15.0"
23+
"node": ">=18"
2424
},
2525
"dependencies": {
2626
"@apollo/federation-internals": "2.13.0-preview.1",

0 commit comments

Comments
 (0)