KAFKA-20297 Move OperatingSystem, Java, Exit... into internal (#22093)

We have exposed several classes in org.apache.kafka.common.utils as
public APIs, which can be misleading since not all classes in this
package are intended for external use.

So move following class into internal module
- OperatingSystem
- Java
- Exit
- Shell
- LoggingSignalHandler

Reviewers: cychiu <cychiu8@gmail.com>, Chia-Ping Tsai
 <chia7712@gmail.com>

Author: m1a2st

clients/src/main/java/org/apache/kafka/common/internals/FatalExitError.java

@@ -16,7 +16,7 @@
  */
 package org.apache.kafka.common.internals;
 
-import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.internals.Exit;
 
 /**
  * An error that indicates the need to exit the JVM process. This should only be used by the server or command-line

clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosError.java

@@ -18,7 +18,7 @@
 
 import org.apache.kafka.common.KafkaException;
 import org.apache.kafka.common.security.authenticator.SaslClientAuthenticator;
-import org.apache.kafka.common.utils.Java;
+import org.apache.kafka.common.utils.internals.Java;
 
 import org.ietf.jgss.GSSException;
 import org.slf4j.Logger;

clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java

@@ -21,9 +21,9 @@
 import org.apache.kafka.common.security.JaasUtils;
 import org.apache.kafka.common.security.auth.AuthenticateCallbackHandler;
 import org.apache.kafka.common.security.authenticator.AbstractLogin;
-import org.apache.kafka.common.utils.Shell;
 import org.apache.kafka.common.utils.Time;
 import org.apache.kafka.common.utils.internals.KafkaThread;
+import org.apache.kafka.common.utils.internals.Shell;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

clients/src/main/java/org/apache/kafka/common/utils/Utils.java

@@ -20,6 +20,7 @@
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.common.config.ConfigException;
 import org.apache.kafka.common.network.TransferableChannel;
+import org.apache.kafka.common.utils.internals.OperatingSystem;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

…/org/apache/kafka/common/utils/Exit.java …e/kafka/common/utils/internals/Exit.javaclients/src/main/java/org/apache/kafka/common/utils/Exit.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/Exit.java clients/src/main/java/org/apache/kafka/common/utils/Exit.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/Exit.java

@@ -14,9 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.kafka.common.utils;
-
-import org.apache.kafka.common.utils.internals.KafkaThread;
+package org.apache.kafka.common.utils.internals;
 
 /**
  * Internal class that should be used instead of `System.exit()` and `Runtime.getRuntime().halt()` so that tests can

…/org/apache/kafka/common/utils/Java.java …e/kafka/common/utils/internals/Java.javaclients/src/main/java/org/apache/kafka/common/utils/Java.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/Java.java clients/src/main/java/org/apache/kafka/common/utils/Java.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/Java.java

@@ -14,7 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.kafka.common.utils;
+package org.apache.kafka.common.utils.internals;
 
 public final class Java {
 

…a/common/utils/LoggingSignalHandler.java …tils/internals/LoggingSignalHandler.javaclients/src/main/java/org/apache/kafka/common/utils/LoggingSignalHandler.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/LoggingSignalHandler.java clients/src/main/java/org/apache/kafka/common/utils/LoggingSignalHandler.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/LoggingSignalHandler.java

@@ -14,7 +14,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.kafka.common.utils;
+package org.apache.kafka.common.utils.internals;
+
+import org.apache.kafka.common.utils.Utils;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

…/kafka/common/utils/OperatingSystem.java …mon/utils/internals/OperatingSystem.javaclients/src/main/java/org/apache/kafka/common/utils/OperatingSystem.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/OperatingSystem.java clients/src/main/java/org/apache/kafka/common/utils/OperatingSystem.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/OperatingSystem.java

@@ -14,7 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.kafka.common.utils;
+package org.apache.kafka.common.utils.internals;
 
 import java.util.Locale;
 

…org/apache/kafka/common/utils/Shell.java …/kafka/common/utils/internals/Shell.javaclients/src/main/java/org/apache/kafka/common/utils/Shell.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/Shell.java clients/src/main/java/org/apache/kafka/common/utils/Shell.java renamed to clients/src/main/java/org/apache/kafka/common/utils/internals/Shell.java

@@ -14,9 +14,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.kafka.common.utils;
-
-import org.apache.kafka.common.utils.internals.KafkaThread;
+package org.apache.kafka.common.utils.internals;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

…common/utils/ByteBufferUnmapperTest.java …ls/internals/ByteBufferUnmapperTest.javaclients/src/test/java/org/apache/kafka/common/utils/ByteBufferUnmapperTest.java renamed to clients/src/test/java/org/apache/kafka/common/utils/internals/ByteBufferUnmapperTest.java clients/src/test/java/org/apache/kafka/common/utils/ByteBufferUnmapperTest.java renamed to clients/src/test/java/org/apache/kafka/common/utils/internals/ByteBufferUnmapperTest.java

@@ -15,9 +15,8 @@
  * limitations under the License.
  */
 
-package org.apache.kafka.common.utils;
+package org.apache.kafka.common.utils.internals;
 
-import org.apache.kafka.common.utils.internals.ByteBufferUnmapper;
 import org.apache.kafka.test.TestUtils;
 
 import org.junit.jupiter.api.Test;